From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: 707330139@qq.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18929: After the view is created, executed query against the view definition, reported syntax error.
Date: Tue, 20 May 2025 14:02:21 +0900
Message-ID: <aCwM3RSlrD2mk1mT@paquier.xyz> (raw)
In-Reply-To: <614740.1747715486@sss.pgh.pa.us>
References: <18929-077d6b7093b176e2@postgresql.org>
<349f86e9-6922-4fcc-9725-b8a6f0667bea@iki.fi>
<c8706ea7-5a32-434b-bdc8-6cf8e2ad46c1@iki.fi>
<614740.1747715486@sss.pgh.pa.us>
On Tue, May 20, 2025 at 12:31:26AM -0400, Tom Lane wrote:
> In the no-good-deed-goes-unpunished department: it appears from
> buildfarm reports that we need to do something about output
> mismatches in cross-version-upgrade tests due to this commit.
> I didn't yet look more closely.
Yes, the buildfarm is unhappy.
It seems to me that this needs an update of @_unused_view_qualifiers
in AdjustUpgrade.pm to update public.limit_thousand_v_5's qual, like
in the attached. This is needed in v16 and newer branches.
--
Michael
Attachments:
[text/x-diff] fix-upgrade-test.patch (645B, ../aCwM3RSlrD2mk1mT@paquier.xyz/2-fix-upgrade-test.patch)
download | inline diff:diff --git a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pmindex 609275e2c26d..1725fe2f9487 100644--- a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm+++ b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm@@ -538,6 +538,7 @@ my @_unused_view_qualifiers = (
{ obj => 'VIEW public.limit_thousand_v_2', qual => 'onek' },
{ obj => 'VIEW public.limit_thousand_v_3', qual => 'onek' },
{ obj => 'VIEW public.limit_thousand_v_4', qual => 'onek' },
+ { obj => 'VIEW public.limit_thousand_v_5', qual => 'onek' },
# Since 14
{ obj => 'MATERIALIZED VIEW public.compressmv', qual => 'cmdata1' });
[application/pgp-signature] signature.asc (832B, ../aCwM3RSlrD2mk1mT@paquier.xyz/3-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, hlinnaka@iki.fi, 707330139@qq.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18929: After the view is created, executed query against the view definition, reported syntax error.
In-Reply-To: <aCwM3RSlrD2mk1mT@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox