From: Nathan Bossart <nathandbossart@gmail.com>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: evsi@amazon.com
Cc: pgsql-bugs@lists.postgresql.org
Cc: peter@eisentraut.org
Subject: Re: BUG #18920: LOAD '$libdir/plugins' no longer works in 18beta1
Date: Mon, 2 Jun 2025 12:16:59 -0500
Message-ID: <aD3ci7soqldAHtb0@nathan> (raw)
In-Reply-To: <CAFY6G8eGLJmdCCLP=MT9k=URegR6oG6Y1doOJXg65Efnzpz9cg@mail.gmail.com>
References: <18920-b350b1c0a30af006@postgresql.org>
<CAFY6G8eGLJmdCCLP=MT9k=URegR6oG6Y1doOJXg65Efnzpz9cg@mail.gmail.com>
On Mon, Jun 02, 2025 at 11:05:12AM -0300, Matheus Alcantara wrote:
> The problem is how we are sripping the $libdir from module_pathname. I
> think that we should still strip the $libdir from module_pathname when
> expanding from a .control file, but we should not expand via LOAD
> command, since the user may explicitly specify the $libdir prefix as it
> is the case here.
>
> Having this logic on expand_dynamic_library_name() force us to srip the
> $libdir for all scenarios, so I think that a better place to have this
> is on load_external_function() that is called when executing a SQL
> script from an extension.
Thanks for the patch. This seems generally reasonable to me.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, matheusssilv97@gmail.com, evsi@amazon.com, pgsql-bugs@lists.postgresql.org, peter@eisentraut.org
Subject: Re: BUG #18920: LOAD '$libdir/plugins' no longer works in 18beta1
In-Reply-To: <aD3ci7soqldAHtb0@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox