From: Michael Paquier <michael@paquier.xyz>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: n.kalinin@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18944: Assertion Failure in psql with idle_session_timeout Set
Date: Tue, 3 Jun 2025 08:31:16 +0900
Message-ID: <aD40RKgfY4L4wnfL@paquier.xyz> (raw)
In-Reply-To: <CAO6_XqrmYG+V8n1ZWvUfrBt3aHExmysRdxaMNQi0sVYjcmW_WQ@mail.gmail.com>
References: <18944-8a926c30f68387dd@postgresql.org>
<aD1dPMIZzAwMKm7G@paquier.xyz>
<CAO6_XqrmYG+V8n1ZWvUfrBt3aHExmysRdxaMNQi0sVYjcmW_WQ@mail.gmail.com>
On Mon, Jun 02, 2025 at 07:00:26PM +0200, Anthonin Bonnefoy wrote:
> So if that's expected, we may need additional logic to avoid
> increasing piped_syncs when we're after a COPY? On the other hand,
> ignoring the SYNC seems to break the protocol spec expectation that
> "there is one and only one ReadyForQuery sent for each Sync".
Hmm. This stuff stands as it is in the backend COPY code since
c01641f8aed0 from 2003, so there's not much we can do in the backend
or libpq. Adding some specific logic in psql to avoid piped_syncs
seems like the correct move seen from here.
Most of that should be close to ExecQueryAndProcessResults(), don't
you think? That's where we count the number of piped syncs.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../aD40RKgfY4L4wnfL@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, anthonin.bonnefoy@datadoghq.com, n.kalinin@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18944: Assertion Failure in psql with idle_session_timeout Set
In-Reply-To: <aD40RKgfY4L4wnfL@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox