pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Cc: Duncan Sands <duncan.sands@deepbluecap.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Subject: Re: Logical replication 'invalid memory alloc request size 1585837200' after upgrading to 17.5
Date: Tue, 24 Jun 2025 13:58:43 +0900
Message-ID: <aFowg2mxXDrrh8CG@paquier.xyz> (raw)
In-Reply-To: <CAD21AoACfSCfWv=Jtq2AjDyAKspkhNHN7ePvXyASMphYuDJPuw@mail.gmail.com>
References: <CAD21AoBfFEG=y=sHrhOO-EWpcFW=PmXcFhkPGYF+O0AH+bRo6w@mail.gmail.com>
	<dbf561f7-465e-4086-adfa-733b9b9a34b3@gmail.com>
	<CALDaNm0=KzQ8TTwTwSgZgvYwccWJU9rpFwTZYNFE1zAFLtSw3g@mail.gmail.com>
	<OSCPR01MB14966F91DBCAEA80EDEE67842F57CA@OSCPR01MB14966.jpnprd01.prod.outlook.com>
	<CALDaNm1Fx+zzudTi1aoE9nFef_p4H-qbOcvF9_qRanNLtwU-tA@mail.gmail.com>
	<CAA4eK1JjGrMsLoMdCynBLkPW5oTPsgpZKyJTP1g6YV+mmV-zWw@mail.gmail.com>
	<CAD21AoD736ECsU-FR5x+hp87vuZzOc1N3sknvSwKuW=XEz0Jgw@mail.gmail.com>
	<OSCPR01MB14966CD70FA2144C1F972647BF579A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
	<CAD21AoAf6-j0vPTpzUj-Q2ySPo-jW11+-pN3kmeSBypgwUZaSg@mail.gmail.com>
	<CAD21AoACfSCfWv=Jtq2AjDyAKspkhNHN7ePvXyASMphYuDJPuw@mail.gmail.com>

On Tue, Jun 24, 2025 at 10:24:03AM +0900, Masahiko Sawada wrote:
> I've added the patch for that idea for discussion. I considered moving
> the new cache-behavior-dependent test to another test file to minimize
> the maintenance effort but didn't do that at this stage as the test
> file has only a few tests.

The spec test file only includes two short permutations, making the
generated output really short.  A secondary output file sounds fine to
me as long as you document in the spec file the reason why the file is
around, and your patch does that.

+# This file contains cache-behavior-dependent test case. Their reults are
[..]
+# two expected-output files to cvoer both cases. 

Two typos in three lines of comments: s/reults/results/ and
s/cvoer/cover/.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../aFowg2mxXDrrh8CG@paquier.xyz/2-signature.asc)
  download

view thread (94+ messages)  latest in thread

Message-ID: <aFowg2mxXDrrh8CG@paquier.xyz>
Permalink:  ../aFowg2mxXDrrh8CG@paquier.xyz/
Also on:    postgresql.org/message-id/aFowg2mxXDrrh8CG@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, sawada.mshk@gmail.com, kuroda.hayato@fujitsu.com, amit.kapila16@gmail.com, vignesh21@gmail.com, pgsql-bugs@lists.postgresql.org, duncan.sands@deepbluecap.com, exclusion@gmail.com
  Subject: Re: Logical replication 'invalid memory alloc request size 1585837200' after upgrading to 17.5
  In-Reply-To: <aFowg2mxXDrrh8CG@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox