From: Nathan Bossart <nathandbossart@gmail.com>
To: gorcom2012@gmail.com
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18993: [BUG] Unreachable code in pg_next_dst_boundary()
Date: Mon, 21 Jul 2025 09:29:32 -0500
Message-ID: <aH5OzOYbypP8QFKv@nathan> (raw)
In-Reply-To: <18993-fd78c35834306695@postgresql.org>
References: <18993-fd78c35834306695@postgresql.org>
On Mon, Jul 21, 2025 at 12:29:16PM +0000, PG Bug reporting form wrote:
> In pg_next_dst_boundary() (src/timezone/localtime.c), the following
> condition can never be true:
> ```
> if (tcycles - icycles >= 1 || icycles - tcycles >= 1)
> return -1;
> ```
> This is unreachable because icycles is assigned directly from tcycles.
I see the following upstream commit and discussion related to this:
https://github.com/eggert/tz/commit/b0bf6d8https://mm.icann.org/pipermail/tz/2013-August/019493.html
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, gorcom2012@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18993: [BUG] Unreachable code in pg_next_dst_boundary()
In-Reply-To: <aH5OzOYbypP8QFKv@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox