From: Michael Paquier <michael@paquier.xyz>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: y@lll.gd
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18986: SIGSEGV in nodeModifyTable.c during Parallel Execution
Date: Wed, 16 Jul 2025 19:48:55 +0900
Message-ID: <aHeDl-0OuIA-MJtt@paquier.xyz> (raw)
In-Reply-To: <CAEZATCUahLe8Lvi7XHV6Eo=Tg46iJ2Rmfw0k6AH5GQbfOjENHQ@mail.gmail.com>
References: <18986-e7a8aac3d339fa47@postgresql.org>
<937261.1752603233@sss.pgh.pa.us>
<aHbt_HkrM3TTH61j@paquier.xyz>
<CAEZATCUj7u_9MTDYZ7hzaf4uf1WrJ+fA3_M4dQKRvua0nP8sMg@mail.gmail.com>
<CAEZATCUahLe8Lvi7XHV6Eo=Tg46iJ2Rmfw0k6AH5GQbfOjENHQ@mail.gmail.com>
On Wed, Jul 16, 2025 at 11:42:33AM +0100, Dean Rasheed wrote:
> Attached is a reproducer using the merge-match-recheck isolation test.
>
> I believe that the bug only goes back to v17, because MERGE could not
> appear inside a CTE prior to that.
That was fast, nice!
> I think that best thing to do is pass the commandType to
> ExecBRUpdateTriggers(), except that in v17 we shouldn't change the
> signature of ExecBRUpdateTriggers(), so a wrapper function will be
> needed, similar to what 9321c79 did.
Yes, changing ExecBRUpdateTriggers() would not be a good idea on a
stable branch.. I can see that at least timescaledb does a direct
call to it. A minor upgrade breakage would be bad for them.
> Question: Is it OK to change the signature of ExecBRUpdateTriggers()
> in v18?
We are still in beta, so that's not a problem for v18 and HEAD.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../aHeDl-0OuIA-MJtt@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, dean.a.rasheed@gmail.com, tgl@sss.pgh.pa.us, y@lll.gd, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18986: SIGSEGV in nodeModifyTable.c during Parallel Execution
In-Reply-To: <aHeDl-0OuIA-MJtt@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox