From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: mert@futo.org
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset extension parameters that no longer exist
Date: Fri, 1 Aug 2025 17:01:47 -0500
Message-ID: <aI05S9BjQ3CsDTud@nathan> (raw)
In-Reply-To: <aIpuzKVndJrI48B1@nathan>
References: <aFXQmZ2sveFAwdjY@nathan>
<aFXlRTxMxVyMjfjq@nathan>
<aFwebUErRdEKZy6i@nathan>
<803ddef427b9016be04af9320925e9570d3fcc06.camel@cybertec.at>
<aIJfucaqjZ3gh-xj@nathan>
<8902b6f8d5c19f09f4a052295b9de41d9f6970b5.camel@cybertec.at>
<aIORdQ-PJ15k-WjZ@nathan>
<aIfoWKXanBNGhdwt@nathan>
<768341.1753738070@sss.pgh.pa.us>
<aIpuzKVndJrI48B1@nathan>
Committed.
On Wed, Jul 30, 2025 at 02:13:16PM -0500, Nathan Bossart wrote:
> It applies relatively cleanly down to v15. The only thing I had to change
> was to replace guc_free() with free() on v15. I was a little worried about
> changing the signature of check_GUC_name_for_parameter_acl(), but
> codesearch.debian.net doesn't show any outside uses.
I ended up skipping the back-patch of commit 2d870b4 to avoid the ABI
breakage. That means ALTER SYSTEM remains broken for this use-case on v15
and v16, but IIUC it's already pretty broken in this area, so I'm not sure
we care too much.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, laurenz.albe@cybertec.at, mert@futo.org, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset extension parameters that no longer exist
In-Reply-To: <aI05S9BjQ3CsDTud@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox