From: Nathan Bossart <nathandbossart@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: mert@futo.org
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset extension parameters that no longer exist
Date: Thu, 24 Jul 2025 11:30:49 -0500
Message-ID: <aIJfucaqjZ3gh-xj@nathan> (raw)
In-Reply-To: <803ddef427b9016be04af9320925e9570d3fcc06.camel@cybertec.at>
References: <18964-ba09dea8c98fccd6@postgresql.org>
<aFW8R6Qlgtbp7TOk@nathan>
<2474668.1750451081@sss.pgh.pa.us>
<aFXQmZ2sveFAwdjY@nathan>
<aFXlRTxMxVyMjfjq@nathan>
<aFwebUErRdEKZy6i@nathan>
<803ddef427b9016be04af9320925e9570d3fcc06.camel@cybertec.at>
On Tue, Jul 22, 2025 at 04:27:24AM +0200, Laurenz Albe wrote:
> I tested your patch, and it works as expected for
Thanks for reviewing.
> There is still one piece missing in my opinion:
>
> ALTER SYSTEM RESET testext.swap_limit;
> ERROR: invalid configuration parameter name "testext.swap_limit"
> DETAIL: "testext" is a reserved prefix.
>
> I think that this case should work like the others.
Good catch. This should be fixed in v3.
> I'd like to see regression tests for this, but I am not sure how
> to best devise them.
> One idea would be to stick them into the regression tests of some
> contrib module, even though it is not the perfect place.
Added in v3.
--
nathan
Attachments:
[text/plain] v3-0001-Allow-resetting-unknown-custom-GUCs-with-reserved.patch (0B, ../aIJfucaqjZ3gh-xj@nathan/2-v3-0001-Allow-resetting-unknown-custom-GUCs-with-reserved.patch)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, laurenz.albe@cybertec.at, tgl@sss.pgh.pa.us, mert@futo.org, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset extension parameters that no longer exist
In-Reply-To: <aIJfucaqjZ3gh-xj@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox