From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: kristianlejao@gmail.com
Subject: Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c
Date: Thu, 7 Aug 2025 12:38:55 +0900
Message-ID: <aJQfz3G-ZipUNTRx@paquier.xyz> (raw)
In-Reply-To: <CAD21AoBpo6Gx55FBOW+9s5X=nUw3Xpq64v35fpDEKsTERnc4TQ@mail.gmail.com>
References: <CAD21AoBpo6Gx55FBOW+9s5X=nUw3Xpq64v35fpDEKsTERnc4TQ@mail.gmail.com>
On Tue, Aug 05, 2025 at 11:00:54AM -0700, Masahiko Sawada wrote:
> The attached patch includes the draft fix and regression tests (using
> injection points).
+$psql_session->query_safe(qq[
+ select injection_points_set_local();
+ select injection_points_attach('heapam_lock_tuple-before-lock', 'wait');
+]);
It seems to me that an isolation test would be a better fit here. TAP
tests are usually a good fit for injection points if you need to do
direct node manipulations, like restarts or stops. The whole test
posted only does SQL-ish things, and you could rely on a loopback
server as we do in the SQL tests of postgres_fdw?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../aJQfz3G-ZipUNTRx@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, sawada.mshk@gmail.com, pgsql-bugs@lists.postgresql.org, kristianlejao@gmail.com
Subject: Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c
In-Reply-To: <aJQfz3G-ZipUNTRx@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox