pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: wangsh.fnst@fujitsu.com, osumi.takamichi@fujitsu.com, pgsql-bugs@lists.postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: "unexpected duplicate for tablespace" problem in logical replication
Date: Fri, 22 Aug 2025 06:36:56 +0900
Message-ID: <aKeReH7_GwoMUoLi@paquier.xyz> (raw)
In-Reply-To: <CAExHW5vojKfVMYij=bU3NgPS8ajx7udB1CiibqJruYj71JcoNw@mail.gmail.com>
References: <20240116.105804.1924548897701268962.horikyota.ntt@gmail.com>
	<CA+TgmoYADF0ddp4JO_a8AiUDKCLFGTAw7ii8OniLBzmwVG8njg@mail.gmail.com>
	<Zffgupps4Gv9BVXL@paquier.xyz>
	<CAD21AoAcGtSOxp-6b7JWVNsyuefk2QwLN2aF2Ki+1bq+X=6fzA@mail.gmail.com>
	<CALDaNm2b3XtaA6GQCD55z-eOyxXR2s_oBifesb7FgpKLJNYR0A@mail.gmail.com>
	<CAExHW5vaHu=s6eopJ2jxyGNRG--uEsJwYk92yxa2L_80+Y=1YA@mail.gmail.com>
	<CAExHW5vBePcL9iEFasECB-wmYksZ9nUVnjnzOqkHYvtbCn==0A@mail.gmail.com>
	<CAExHW5uaSBDktUEyohUYy_QGRZgN=zd=B9gdp2MyDMJZOCisBg@mail.gmail.com>
	<aKa4wnxX6h2siDIq@paquier.xyz>
	<CAExHW5vojKfVMYij=bU3NgPS8ajx7udB1CiibqJruYj71JcoNw@mail.gmail.com>

On Thu, Aug 21, 2025 at 07:54:55PM +0530, Ashutosh Bapat wrote:
> How about the following:
> 
> ---
> Map a relation's (tablespace, relfilenumber) to a relation's oid and
> cache the result.
> 
> A temporary relation may have the same relfilenumber as a permanent
> relation, or as other temporary relations. In order to uniquely
> identify a temporary relation we also need the
> proc number of the backend which created it. The proc number is not
> available to this function. Hence ignore temporary relations.
> 
> Returns InvalidOid if no permanent relation matching the criteria
> could be found.
> ---

That's simpler.

> Said that if you insist on adding just "Temporary relations are not
> supported", we can go ahead with it.

That would be simpler as well, providing the information.

> Vignesh, since you are the original author of the patch, do you want
> to take care of addressing the comments? Otherwise I can.

It's fine.  I am going to take care of that.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../aKeReH7_GwoMUoLi@paquier.xyz/2-signature.asc)
  download

view thread (25+ messages)  latest in thread

Message-ID: <aKeReH7_GwoMUoLi@paquier.xyz>
Permalink:  ../aKeReH7_GwoMUoLi@paquier.xyz/
Also on:    postgresql.org/message-id/aKeReH7_GwoMUoLi@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, ashutosh.bapat.oss@gmail.com, vignesh21@gmail.com, sawada.mshk@gmail.com, robertmhaas@gmail.com, horikyota.ntt@gmail.com, andres@anarazel.de
  Subject: Re: "unexpected duplicate for tablespace" problem in logical replication
  In-Reply-To: <aKeReH7_GwoMUoLi@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox