pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Xuneng Zhou <xunengzhou@gmail.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: ryanzxg@gmail.com, pgsql-bugs@lists.postgresql.org, Euler Taveira <euler@eulerto.com>
Subject: Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18
Date: Sat, 1 Nov 2025 09:17:25 +0900
Message-ID: <aQVRlV6ZOsUz5fd1@paquier.xyz> (raw)
In-Reply-To: <CABPTF7UR3CTc5m0Gzkm-18qnbXTujYzCicmRatOYsMr1LQ+z3g@mail.gmail.com>
References: <19093-c4fff49a608f82a0@postgresql.org>
	<CABPTF7XKZV2d4eWhH0ybfv5J0hHyzPxPDmebzQXsSt-8XvO1sA@mail.gmail.com>
	<20251027041241.ab.nmisch@google.com>
	<aQGfoKGgmAbPATp5@paquier.xyz>
	<CABPTF7VsyWXAQyc-qc8i1OkwsP5hWE6WoGVCH1zbiUhX0=rFCw@mail.gmail.com>
	<aQKlC1v2_MXGV6_9@paquier.xyz>
	<CABPTF7XE--Dc97LXj5Xum1U4v5=CQnrVYFbVjWTWu4J7gCNXAg@mail.gmail.com>
	<aQQqBUuRAS38u3w8@paquier.xyz>
	<CABPTF7UR3CTc5m0Gzkm-18qnbXTujYzCicmRatOYsMr1LQ+z3g@mail.gmail.com>

On Fri, Oct 31, 2025 at 06:50:06PM +0800, Xuneng Zhou wrote:
> On Fri, Oct 31, 2025 at 11:16 AM Michael Paquier <michael@paquier.xyz> wrote:
>>
>> On Fri, Oct 31, 2025 at 12:07:01AM +0800, Xuneng Zhou wrote:
>> > Using a wrapper function seems better here.
>>
>> For a cleaner git history, the wrapper function and the assertion
>> should be split as its own commit, with the actual fix applied first.
>> Just an opinion.
> 
> It makes sense to me. I've split the patch for HEAD into three patch
> sets.  Please see the attached files.

Thanks, that looks sensible.  I'll revisit what you have at the
beginning of next week (local Tuesday) with a backpatch down to v13 in
mind.  If others have comments and/or objections, please feel free to
chime in.

Note that the changes in 040_standby_failover_slots_sync.pl are not
needed in v3-0001.  No need to send an updated patch just for that.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../aQVRlV6ZOsUz5fd1@paquier.xyz/2-signature.asc)
  download

view thread (21+ messages)  latest in thread

Message-ID: <aQVRlV6ZOsUz5fd1@paquier.xyz>
Permalink:  ../aQVRlV6ZOsUz5fd1@paquier.xyz/
Also on:    postgresql.org/message-id/aQVRlV6ZOsUz5fd1@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, xunengzhou@gmail.com, noah@leadboat.com, euler@eulerto.com
  Subject: Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18
  In-Reply-To: <aQVRlV6ZOsUz5fd1@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox