From: Nathan Bossart <nathandbossart@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Олег Самойлов <splarv@ya.ru>
Cc: pgsql-bugs@lists.postgresql.org, Álvaro Herrera <alvherre@kurilemu.de>
Subject: Re: basic_archive lost archive_directory
Date: Mon, 9 Feb 2026 15:48:05 -0600
Message-ID: <aYpWFcfk1xueHiCc@nathan> (raw)
In-Reply-To: <CAHGQGwF3tFP=oQgYHoS3h9TMeFbZwXc6+xdPTW8CkMV2TkjTmg@mail.gmail.com>
References: <202601301728.sfkizrto3t5i@alvherre.pgsql>
<9b9341b0-942e-4d34-b94f-92bd918fad04@ya.ru>
<1317421770387925@cea5cfd9-50d3-4d85-a924-a7cc75f8f215>
<CAHGQGwF3tFP=oQgYHoS3h9TMeFbZwXc6+xdPTW8CkMV2TkjTmg@mail.gmail.com>
On Tue, Feb 10, 2026 at 02:46:39AM +0900, Fujii Masao wrote:
> Basically I like the idea of moving the checks for archive_directory from
> check_archive_directory() to basic_archive_configured(). This would not only
> address this issue, but also other problems caused by performing these checks
> in the GUC check hook.
Note that the check_configured_cb is called for every segment to archive.
That means we'd be calling stat() much more, which seems like unnecessary
overhead to me. And we still need to be prepared for the archive directory
to disappear at any time. I'm wondering if it would be better to simply
remove this archive directory existence check from the check_configured_cb.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: nathandbossart@gmail.com, masao.fujii@gmail.com, sk@zsrv.org, splarv@ya.ru, alvherre@kurilemu.de
Subject: Re: basic_archive lost archive_directory
In-Reply-To: <aYpWFcfk1xueHiCc@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox