pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org, Fujii Masao <masao.fujii@oss.nttdata.com>
Subject: Re: BUG #17928: Standby fails to decode WAL on termination of primary
Date: Wed, 20 Sep 2023 09:00:00 +0300
Message-ID: <ab22a3c7-8045-f30c-ebbf-ac5cbae0b739@gmail.com> (raw)
In-Reply-To: <CA+hUKGKp_Go=EqA65r6naxrmXFfD-uH3DwPbm7tRCu9d2T=VyQ@mail.gmail.com>
References: <CA+hUKGJV1Ow_S86Fj25J_orojXkn4WPeARyY8-Xr88c85rJHEQ@mail.gmail.com>
	<ZPaq3KwARVHWzune@paquier.xyz>
	<ZP+4YYrPZk0GFlc3@paquier.xyz>
	<CA+hUKG+=jiXcE9uOkf3KHDb_ZAkjahQ8jzBXsEOAoXH=y0Z=uw@mail.gmail.com>
	<ZP/I93ZSL0Mvt5rS@paquier.xyz>
	<CA+hUKGKj3vgopo9YC3hk7zDgkAGAA+aP6ZPGgTa-QVLvn7EK7A@mail.gmail.com>
	<ZQTwsT6tsbx6BYn3@paquier.xyz>
	<CA+hUKGJOXdpWO_6wK0q3jsEwk5cJ6fAQj1T1mE9cFj6R+tPtrw@mail.gmail.com>
	<c3f123ca-03f7-b7ce-1e49-f8fee4c16545@gmail.com>
	<CA+hUKGK53D8OYxTQiQ9qzJsA7ymcHTqqh7V_PUM06TCT=HOJqg@mail.gmail.com>
	<ZQlvihvHo5JspVpV@paquier.xyz>
	<CA+hUKGJVke-Dwy8-ehuCj_cF8d94C-L3gR8G5=wA967FgFimGA@mail.gmail.com>
	<ee604ee6-f464-1502-0289-f1046c85c182@gmail.com>
	<CA+hUKGKp_Go=EqA65r6naxrmXFfD-uH3DwPbm7tRCu9d2T=VyQ@mail.gmail.com>

20.09.2023 01:51, Thomas Munro wrote:
> The solution in this version is to call get_insert_len() instead of
> using the result of emit_message() for the values returned by the
> advance_XXX() functions.  The result of emit_message() is actually the
> LSN of the following COMMIT record so can't be used directly for
> building xl_prev chains.
>
>> And may be "xlp_prev" is a typo?
> Fixed.

I've retested this version (patches for all branches, plus wal_log_hints,
plus Valgrind, and also retested code changes with my
099_restart_with_stanby.pl) and found no issues. IMHO, this patch is
ready to float off.

Thank you!

Best regards,
Alexander





view thread (86+ messages)  latest in thread

Message-ID: <ab22a3c7-8045-f30c-ebbf-ac5cbae0b739@gmail.com>
Permalink:  ../ab22a3c7-8045-f30c-ebbf-ac5cbae0b739@gmail.com/
Also on:    postgresql.org/message-id/ab22a3c7-8045-f30c-ebbf-ac5cbae0b739@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: exclusion@gmail.com, thomas.munro@gmail.com, michael@paquier.xyz, sk@zsrv.org, noah@leadboat.com, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, masao.fujii@oss.nttdata.com
  Subject: Re: BUG #17928: Standby fails to decode WAL on termination of primary
  In-Reply-To: <ab22a3c7-8045-f30c-ebbf-ac5cbae0b739@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox