pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
To: Tender Wang <tndrwang@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: David Rowley <dgrowleyml@gmail.com>
Subject: Re: "type with xxxx does not exist" when doing ExecMemoize()
Date: Wed, 28 Feb 2024 14:25:04 +0700
Message-ID: <abb6240f-4fa9-47a0-8b4d-89573ad957fc@postgrespro.ru> (raw)
In-Reply-To: <CAHewXNknsjG6JoDM48FWyyiFesG=K18vJMOY_LzPBDNV7DvmuQ@mail.gmail.com>
References: <CAHewXNnT6N6UJkya0z-jLFzVxcwGfeRQSfhiwA+NyLg-x8iGew@mail.gmail.com>
	<d3da9856-0394-48e6-9f41-543c589e9585@postgrespro.ru>
	<CAHewXNm9KEn8CMOK4q0zutkX4BK8o754LgQbzYKgcj7_g1GgjQ@mail.gmail.com>
	<7a6a807c-193f-4333-937b-8211b1330579@postgrespro.ru>
	<CAMbWs481ZsCBi+63mRatE0VByijSFwhu=OBARFptM4rsza-2Yw@mail.gmail.com>
	<aacdf19f-778d-4a92-a2ba-2fa5f56401b4@postgrespro.ru>
	<CAHewXNknsjG6JoDM48FWyyiFesG=K18vJMOY_LzPBDNV7DvmuQ@mail.gmail.com>

On 28/2/2024 13:53, Tender Wang wrote:
> The attached patch is a new version based on v3(not including Andrei's 
> the test case). There is no need to call datumCopy when
> isnull is true.
> 
> I have not added a new runtime memoryContext so far. Continue to use 
> mstate->tableContext, I'm not sure the memory used of probeslot will 
> affect mstate->mem_limit.
> Maybe adding a new memoryContext is better. I think I should spend a 
> little time to learn nodeMemoize.c more deeply.
I am curious about your reasons to stay with tableContext. In terms of 
memory allocation, Richard's approach looks better.
Also, You don't need to initialize tts_values[i] at all if tts_isnull[i] 
set to true.

-- 
regards,
Andrei Lepikhov
Postgres Professional






view thread (19+ messages)  latest in thread

Message-ID: <abb6240f-4fa9-47a0-8b4d-89573ad957fc@postgrespro.ru>
Permalink:  ../abb6240f-4fa9-47a0-8b4d-89573ad957fc@postgrespro.ru/
Also on:    postgresql.org/message-id/abb6240f-4fa9-47a0-8b4d-89573ad957fc@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: a.lepikhov@postgrespro.ru, tndrwang@gmail.com, guofenglinux@gmail.com, pgsql-hackers@lists.postgresql.org, dgrowleyml@gmail.com
  Subject: Re: "type with xxxx does not exist" when doing ExecMemoize()
  In-Reply-To: <abb6240f-4fa9-47a0-8b4d-89573ad957fc@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox