From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Euler Taveira <euler@eulerto.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: chenjq.jy@fujitsu.com, pgsql-bugs@lists.postgresql.org, Julien Rouhaud <rjuju123@gmail.com>
Subject: Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command
Date: Wed, 18 Aug 2021 13:44:00 +0200
Message-ID: <acde4807-7cd4-2c15-b73a-ac8e71c71191@enterprisedb.com> (raw)
In-Reply-To: <429f6e0e-31eb-4741-8bf8-e9e827b3076d@www.fastmail.com>
References: <17148-b5087318e2b04fc6@postgresql.org>
<B9A9C944-9EAC-421C-8044-EF109ADAC4D4@yesql.se>
<A6A434CC-AA6D-4DD2-A26E-B6E226CCAD9B@yesql.se>
<fb17eac7-f5cf-4e6f-9b67-f5fb4855d1d9@www.fastmail.com>
<F5A1A42D-184C-46B7-8FBF-17AA000D28E0@yesql.se>
<429f6e0e-31eb-4741-8bf8-e9e827b3076d@www.fastmail.com>
On 17.08.21 19:00, Euler Taveira wrote:
>> Well, problem is that it’s plain not true. If you pass --quiet
>> --verbose you
>> will get a lot of output, albeit less than if not using --quiet.
>> Consistency
>> with other tools is obviously good, but only when it’s correct IMO.
> Indeed, it is not a good design. It should be one option --verbose that
> increases the verbosity according to a number or an enum value. --verbose=0
> means "quiet". However, that ship has sailed.
I was confused by this the other day as well. Having all of
-q, --quiet don't write any messages
-P, --progress show progress information
-v, --verbose write a lot of output
is surely a lot.
If you look at what --quiet does, it
1) disables logging warnings if there are no matches for object patterns
and --no-strict-names is given, and
2) sets PQsetErrorVerbosity(free_slot->connection, PQERRORS_TERSE).
I think this both of these things could be deleted and we could get rid
of the --quiet option, to simplify all this. Neither of these behaviors
is in common with any other PostgreSQL tool.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, euler@eulerto.com, daniel@yesql.se, rjuju123@gmail.com
Subject: Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command
In-Reply-To: <acde4807-7cd4-2c15-b73a-ac8e71c71191@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox