pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Jawarilal, Manish <Manish.Jawarilal@dell.com>
Subject: Re: pgbench bug / limitation
Date: Sat, 6 Jun 2020 08:59:57 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2006060851480.32228@pseudo> (raw)
In-Reply-To: <1510961.1591380652@sss.pgh.pa.us>
References: <BL0PR1901MB198583EAC6C8A3B770D20F1AED8A0@BL0PR1901MB1985.namprd19.prod.outlook.com>
	<384920.1591027137@sss.pgh.pa.us>
	<CAApHDvrjWtJa9oQ98oH+9PCvTgOkGZP+gcmottNX95sjn6o9fQ@mail.gmail.com>
	<512846.1591057287@sss.pgh.pa.us>
	<CAApHDvpMEAaZMxtzixbnb7ySo=Kb1eUfshEB-y4YOm8SgGrpiw@mail.gmail.com>
	<alpine.DEB.2.22.394.2006021258170.87735@pseudo>
	<CAApHDvpDBkjj6a+Ld-9YGW=_Bcxss8Yyz_QYjtjus3WUsTb+1g@mail.gmail.com>
	<1507639.1591375547@sss.pgh.pa.us>
	<D973F4AF-8949-42C1-ABF1-E87F7C63E746@anarazel.de>
	<1509305.1591378355@sss.pgh.pa.us>
	<20200605174418.zbb4egfe5wxhv2yd@alap3.anarazel.de>
	<1510961.1591380652@sss.pgh.pa.us>


Hello Tom,

> Agreed.  Seems like the best answer is to get in bed with the Windows
> representation of fd_set, since we cannot avoid knowing that it is
> different from other platforms' versions.  I suggest that we might as
> well get all the way in and dodge the FD_SETSIZE limitation altogether,
> as per the attached utterly-untested draft patch.

ISTM that the patch your propose, a full reimplementation of the abstract 
poll/select fd set interface for windows, is overkill because it adds 
about 80 lines of code. ISTM that just redefining some macros is enough to 
get the same performance benefit without adding much to the code base, but 
maybe I'm missing something. At least, I do not think that getting rid of 
the FD_SETSIZE redefinition for windows is worth all that trouble.

-- 
Fabien.





view thread (26+ messages)  latest in thread

Message-ID: <alpine.DEB.2.22.394.2006060851480.32228@pseudo>
Permalink:  ../alpine.DEB.2.22.394.2006060851480.32228@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.22.394.2006060851480.32228@pseudo

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: coelho@cri.ensmp.fr, tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-bugs@lists.postgresql.org, dgrowleyml@gmail.com, Manish.Jawarilal@dell.com
  Subject: Re: pgbench bug / limitation
  In-Reply-To: <alpine.DEB.2.22.394.2006060851480.32228@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox