From: Michael Paquier <michael@paquier.xyz>
To: shihao zhong <zhong950419@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: theshallow27@gmail.com <theshallow27@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19730: PostgreSQL `pg_backup_start` accepts newlines in the backup label, producing an unrestorable `backup
Date: Fri, 2 Oct 2026 13:32:20 +0900
Message-ID: <ar8z1ClV9rWfAxVo@paquier.xyz> (raw)
In-Reply-To: <CAGRkXqS7znpXT6P-iLnTZthnMm1EtUx+N8yZ-WSkU3i38vi1fg@mail.gmail.com>
References: <19730-85a6044c9e72774a@postgresql.org>
<CAGRkXqTGP7BRT5Xv+xJoSc3egpPtC0h-LH-w4GxzQSt5qg7iLg@mail.gmail.com>
<CAKFQuwbjp=jg5_K3W3pP8cuO68B5R=NOuRRo6ZCvTMyZMyW8rQ@mail.gmail.com>
<ar8px1yG51ESobdm@paquier.xyz>
<CAGRkXqS7znpXT6P-iLnTZthnMm1EtUx+N8yZ-WSkU3i38vi1fg@mail.gmail.com>
On Thu, Oct 01, 2026 at 10:07:41PM -0600, shihao zhong wrote:
> Fair enough. Patch attached. It is the check from the report, with
> the error wording of b380a56a3f95, and a test next to the "backup
> label too long" one in 020_archive_status.pl.
WFM.
> One thing to note. A label that ends with a newline works today, and
> this patch rejects it. A script that reads the label from a file can
> hit that, so I think this should go to master only.
Of course, this is not something that would go into the stable
branches in any way.
Perhaps other will have some comments. Let's see.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../ar8z1ClV9rWfAxVo@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, zhong950419@gmail.com, david.g.johnston@gmail.com, theshallow27@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19730: PostgreSQL `pg_backup_start` accepts newlines in the backup label, producing an unrestorable `backup
In-Reply-To: <ar8z1ClV9rWfAxVo@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox