agora inbox for pgsql-bugs@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: jian he <jian.universality@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: imchifan@163.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19715: pg_restore_attribute_stats() rejects range statistics for a domain over int4multirange
Date: Fri, 25 Sep 2026 07:52:07 +0900
Message-ID: <arWpl7GpyleJ-HjT@paquier.xyz> (raw)
In-Reply-To: <CACJufxFpoeswdX3hV_vg+Tr78Q++01yk06k5Y4aPapYm_-hW3Q@mail.gmail.com>
References: <19715-b8be35083016f289@postgresql.org>
<CADkLM=exLKefGZjw+6HZ4TaVr0ra2+t44=64DpRs5eX4wdqfuw@mail.gmail.com>
<arSlchrpWvs8m8M2@paquier.xyz>
<CADkLM=ci+m6KW1r1RutSOV-OOvv9FTNrOU0+7wNq8R2+p-91Nw@mail.gmail.com>
<CACJufxFpoeswdX3hV_vg+Tr78Q++01yk06k5Y4aPapYm_-hW3Q@mail.gmail.com>
On Thu, Sep 24, 2026 at 02:44:19PM +0800, jian he wrote:
> Similar in import_pg_statistic.
> change to
> typcache = lookup_type_cache(typid, TYPECACHE_LT_OPR |
> TYPECACHE_EQ_OPR | TYPECACHE_DOMAIN_BASE_INFO);
>
> Disclaimer: Since I saw both of you actively working on this issue, I
> haven't tried this myself.
Yes, I was wondering about that a bit, feeding a single typcache entry
across the board. And while looking at the code, I was reminded about
the following exceptions:
extended_stats_funcs.c: if (typid == TSVECTOROID)
stat_utils.c: if (*atttypid == TSVECTOROID)
stat_utils.c: if (atttypid == TSVECTOROID)
I think that the existing code is also broken when defining a domain
over tsvector if we don't feed a domain base type in these three
spots.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../arWpl7GpyleJ-HjT@paquier.xyz/2-signature.asc)
download
view thread (14+ messages) latest in thread
Message-ID: <arWpl7GpyleJ-HjT@paquier.xyz>
Permalink: ../arWpl7GpyleJ-HjT@paquier.xyz/
Also on: postgresql.org/message-id/arWpl7GpyleJ-HjT@paquier.xyz
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, jian.universality@gmail.com, corey.huinker@gmail.com, imchifan@163.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19715: pg_restore_attribute_stats() rejects range statistics for a domain over int4multirange
In-Reply-To: <arWpl7GpyleJ-HjT@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox