From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih.pg@gmail.com>
Cc: Staroverov Ilja <i.staroverov@ftdata.ru>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: pg_stat_statements replaces SQL/JSON ON EMPTY / ON ERROR keywords with parameters
Date: Tue, 27 Oct 2026 08:28:52 +0900
Message-ID: <at_iNExRxGKoaODg@paquier.xyz> (raw)
In-Reply-To: <CAN12+YJukPcK6mu=XJ0=V1rSwEhptjfxBx6nCpp_1RDO6qP4Kg@mail.gmail.com>
References: <457969A9-5D24-422F-B09E-F388053DE028@localhost.localdomain>
<athe8udYm0H_xy0q@paquier.xyz>
<E00D8F2E-7706-4227-8FE9-C899FAFB4C3C@localhost.localdomain>
<atnJJiWcHyhd8_NI@paquier.xyz>
<83202E93-9039-410B-B4F2-A141DD7D80E1@localhost.localdomain>
<atsUfsDjdudiJAL9@paquier.xyz>
<CAN12+YJukPcK6mu=XJ0=V1rSwEhptjfxBx6nCpp_1RDO6qP4Kg@mail.gmail.com>
On Mon, Oct 26, 2026 at 01:23:22PM -0500, Sami Imseih wrote:
> The column names in the SRF column definition list don't make those separate
> entries. I think JSON_TABLE column names should follow the same rule. Explicit
> PATH values are not included in the query ID, so I don't think omitting PATH
> should make the column name part of the query ID.
>
> So I think `JsonExpr.column_name` should be marked `query_jumble_ignore`
> instead of using a custom query jumble function.
Okay. How would this choice impact the PGSS outputs? Perhaps we
should first expand the tests with PATH keywords touching multiple
columns first? I was hesitant to do so while introducing the tests,
and only focused on the obviously-broken case with the ON ERROR/NULL
keywords handled as constants in the PGSS outputs.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, samimseih.pg@gmail.com, i.staroverov@ftdata.ru
Subject: Re: pg_stat_statements replaces SQL/JSON ON EMPTY / ON ERROR keywords with parameters
In-Reply-To: <at_iNExRxGKoaODg@paquier.xyz>
References: <457969A9-5D24-422F-B09E-F388053DE028@localhost.localdomain> <athe8udYm0H_xy0q@paquier.xyz> <E00D8F2E-7706-4227-8FE9-C899FAFB4C3C@localhost.localdomain> <atnJJiWcHyhd8_NI@paquier.xyz> <83202E93-9039-410B-B4F2-A141DD7D80E1@localhost.localdomain> <atsUfsDjdudiJAL9@paquier.xyz> <CAN12+YJukPcK6mu=XJ0=V1rSwEhptjfxBx6nCpp_1RDO6qP4Kg@mail.gmail.com> <at_iNExRxGKoaODg@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox