From: Michael Paquier <michael@paquier.xyz>
To: Zhijie Hou <houzhijie22@gmail.com>
Cc: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: brar@gmx.de <brar@gmx.de>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value
Date: Mon, 2 Nov 2026 08:15:44 +0900
Message-ID: <aufIIObKTqckAqzM@paquier.xyz> (raw)
In-Reply-To: <aubxn5Ny_ehMhwdB@paquier.xyz>
References: <19795-6d7d506133b7f062@postgresql.org>
<CAFvd2n-BDb2rp+8jKyUrf-Uv4YgZqDa+O0gzt_JDfCpC-9gGxA@mail.gmail.com>
<OS7PR01MB18317FEB9D24DE47C5077EF90F5612@OS7PR01MB18317.jpnprd01.prod.outlook.com>
<9bcab85a-edda-4302-bdd0-1c1cf5b7a66c@gmail.com>
<aubxn5Ny_ehMhwdB@paquier.xyz>
On Sun, Nov 01, 2026 at 05:00:31PM +0900, Michael Paquier wrote:
> Thanks for the patch, nice catch. I'll handle that and backpatch.
> I regret missing that during the lookup of this code for 290bb8afe6b4,
> especially as the crash was possible before it for the two code paths
> you are pointing at with the two direct accesses to defel->arg.
Applied down to v14 as of 35848657c67d. Thanks, all.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, houzhijie22@gmail.com, kuroda.hayato@fujitsu.com, brar@gmx.de
Subject: Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value
In-Reply-To: <aufIIObKTqckAqzM@paquier.xyz>
References: <19795-6d7d506133b7f062@postgresql.org> <CAFvd2n-BDb2rp+8jKyUrf-Uv4YgZqDa+O0gzt_JDfCpC-9gGxA@mail.gmail.com> <OS7PR01MB18317FEB9D24DE47C5077EF90F5612@OS7PR01MB18317.jpnprd01.prod.outlook.com> <9bcab85a-edda-4302-bdd0-1c1cf5b7a66c@gmail.com> <aubxn5Ny_ehMhwdB@paquier.xyz> <aufIIObKTqckAqzM@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox