From: David Steele <david@pgmasters.net>
To: Amit Langote <amitlangote09@gmail.com>
To: Pavel Biryukov <79166341370@yandex.ru>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: posgres 12 bug (partitioned table)
Date: Fri, 5 Mar 2021 11:25:12 -0500
Message-ID: <cd492dbd-a0ba-4790-bcf7-c4af2d2dc8d1@pgmasters.net> (raw)
In-Reply-To: <CA+HiwqFjEim_RMCiaFxA4nUx00o3auXKPy-OsOcog+chg5K-zA@mail.gmail.com>
References: <141051591267657@mail.yandex.ru>
<1251598.1591289850@sss.pgh.pa.us>
<20200811180231.fcssvhelqpnydnx7@alap3.anarazel.de>
<CA+HiwqH7bA+orwhcA5dofKR_UNzk-S8GPK23g1vCrWxAjnK=Og@mail.gmail.com>
<81885.1597205290@sss.pgh.pa.us>
<CA+HiwqFx8oBGTDmwVQNHQrSGw4we84E4z5J+q2zFRJeAt5BaCA@mail.gmail.com>
<20200812162718.ycxrktzoe6rpdy5k@alap3.anarazel.de>
<CA+HiwqEGgy8x5M2dotzH7HSd0v+byyJXGU8S+d5NFnrOBiTZDA@mail.gmail.com>
<407111603806900@mail.yandex.ru>
<CA+HiwqFjEim_RMCiaFxA4nUx00o3auXKPy-OsOcog+chg5K-zA@mail.gmail.com>
On 10/28/20 10:01 AM, Amit Langote wrote:
> On Tue, Oct 27, 2020 at 10:55 PM Pavel Biryukov <79166341370@yandex.ru> wrote:
>> Hi!
>>
>> What's the state with this issue?
> I think that the patch that Andres Freund posted earlier on this
> thread [1] would be fine as a workaround at least for stable releases
> v12 and v13. I have attached with this email a rebased version of
> that patch, although I also made a few changes. The idea of the patch
> is to allocate and use a partition-specific *non-virtual* slot, one
> that is capable of providing system columns when the RETURNING
> projection needs them. Andres' patch would allocate such a slot even
> if RETURNING contained no system columns, whereas I changed the slot
> creation code stanza to also check that RETURNING indeed contains
> system columns. I've attached 2 patch files: one for HEAD and another
> for v12 and v13 branches.
>
> That said, the discussion on what to do going forward to *cleanly*
> support accessing system columns through partitioned tables is
> pending, but maybe the "workaround" fix will be enough in the meantime
> (at least v12 and v13 can only get a workaround fix).
> stgresql.org/message-id/20200811180629.zx57llliqcmcgfyr%40alap3.anarazel.de
This thread has been quiet for while. Does everyone agree with Amit's
proposal to use this patch as a workaround?
Also, is there a CF entry for this issue? If so I am unable to find it.
Regards,
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: david@pgmasters.net, amitlangote09@gmail.com, 79166341370@yandex.ru, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org
Subject: Re: posgres 12 bug (partitioned table)
In-Reply-To: <cd492dbd-a0ba-4790-bcf7-c4af2d2dc8d1@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox