From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Cc: steven.winfield@cantabcapital.com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes
Date: Thu, 23 Jan 2020 14:46:08 +0100
Message-ID: <d746fc4c-c47d-2581-e9b2-641b05e350e5@2ndquadrant.com> (raw)
In-Reply-To: <22096.1578965897@sss.pgh.pa.us>
References: <16059-8836946734c02b84@postgresql.org>
<30313.1572729260@sss.pgh.pa.us>
<1628.1572820800@sss.pgh.pa.us>
<6ccd23e4-ce58-c2b5-39a1-801a9937ae86@2ndquadrant.com>
<12699.1578058657@sss.pgh.pa.us>
<32307.1578290788@sss.pgh.pa.us>
<1ed54e8f-d84e-bfbe-ffad-890015e12735@2ndquadrant.com>
<28497.1578947794@sss.pgh.pa.us>
<22096.1578965897@sss.pgh.pa.us>
On 2020-01-14 02:38, Tom Lane wrote:
> I wrote:
>> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>>> I have found a weird behavior with identifier quoting, which is not the
>>> subject of this patch, but it appears to be affected by it.
>
>> I'll think about how to improve this. Given that we're dequoting
>> filenames explicitly anyway, maybe we don't need to tell readline that
>> double-quote is a quoting character. Another idea is that maybe
>> we ought to refactor things so that identifier dequoting and requoting
>> is handled explicitly, similarly to the way filenames work now.
>> That would make the patch a lot bigger though.
>
> On reflection, it seems like the best bet for the moment is to
> remove double-quote from the rl_completer_quote_characters string,
> which should restore all behavior around double-quoted strings to
> what it was before. (We have to keep single-quote in that string,
> though, or quoted file names fail entirely.)
This patch (version 6) looks good to me.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, steven.winfield@cantabcapital.com
Subject: Re: BUG #16059: Tab-completion of filenames in COPY commands removes required quotes
In-Reply-To: <d746fc4c-c47d-2581-e9b2-641b05e350e5@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox