From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped)
Date: Tue, 13 Jul 2021 07:52:20 +0200
Message-ID: <dc29b1131b84bef879cf68d1d1edae07f51ca3d2.camel@cybertec.at> (raw)
In-Reply-To: <2984422.1626110456@sss.pgh.pa.us>
References: <17098-b960f3616c861f83@postgresql.org>
<2468663.1626017338@sss.pgh.pa.us>
<2984422.1626110456@sss.pgh.pa.us>
On Mon, 2021-07-12 at 13:20 -0400, Tom Lane wrote:
> > However, that root issue is converted from a relatively minor bug into
> > a server crash because snprintf.c treats a NULL pointer passed to %s
> > as a crash-worthy error. I have advocated for that behavior in the
> > past, but I'm starting to wonder if it wouldn't be wiser to change
> > over to the glibc-ish behavior of printing "(null)" or the like.
>
> So my feeling about this is that switching snprintf.c's behavior
> would produce some net gain in robustness for v12 and up, while
> not making things any worse for the older branches. I still hold
> to the opinion that we've already flushed out all the cases of
> passing NULL that we're likely to find via ordinary testing.
New cases could be introduced in the future and might remain undetected.
What about adding an Assert that gags on NULLs, but still printing them
as "(null)"? That would help find such problems in a debug build.
Yours,
Laurenz Albe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: laurenz.albe@cybertec.at, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped)
In-Reply-To: <dc29b1131b84bef879cf68d1d1edae07f51ca3d2.camel@cybertec.at>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox