pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Ranier Vilela <ranier.vf@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped)
Date: Thu, 22 Jul 2021 10:24:05 -0400
Message-ID: <780310.1626963845@sss.pgh.pa.us> (raw)
In-Reply-To: <768db26c-cf9a-6943-38b1-2d5ac8cc86f2@enterprisedb.com>
References: <17098-b960f3616c861f83@postgresql.org>
	<2468663.1626017338@sss.pgh.pa.us>
	<2984422.1626110456@sss.pgh.pa.us>
	<dc29b1131b84bef879cf68d1d1edae07f51ca3d2.camel@cybertec.at>
	<3227956.1626186568@sss.pgh.pa.us>
	<CAEudQAq22dUhHp9ryKNOnro0HkQWiJE1F3g3VxHUFsqQ4ZkyeA@mail.gmail.com>
	<3280448.1626200778@sss.pgh.pa.us>
	<06a9ff0f-d1e9-0340-2f3b-180cefe41c7a@enterprisedb.com>
	<3517180.1626280000@sss.pgh.pa.us>
	<768db26c-cf9a-6943-38b1-2d5ac8cc86f2@enterprisedb.com>

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 14.07.21 18:26, Tom Lane wrote:
>> https://git.musl-libc.org/cgit/musl/tree/src/stdio/vfprintf.c#n593
>> case 's':
>> a = arg.p ? arg.p : "(null)";

> Similar here: 
> https://github.com/ensc/dietlibc/blob/master/lib/__v_printf.c#L188

I also took a look at μClibc, as well as glibc itself, and learned some
additional facts.  glibc's behavior is not just 'print "(null)" instead'.
It is 'print "(null)" if the field width allows at least six characters,
otherwise print nothing'.  μClibc is bug-compatible with this, but other
implementations seem to generally just substitute "(null)" for the input
string and run with that.  I'm inclined to side with the latter camp.
I'd rather see something like "(nu" than empty because the latter looks
too much like it might be correct output; so I think glibc is expending
extra code to produce a less-good result.

> I think unless we get counterexamples, this is all good.

Barring objections, I'll press ahead with changing snprintf.c to do this.

			regards, tom lane





view thread (13+ messages)

Message-ID: <780310.1626963845@sss.pgh.pa.us>
Permalink:  ../780310.1626963845@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/780310.1626963845@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, ranier.vf@gmail.com, laurenz.albe@cybertec.at, pgsql-hackers@lists.postgresql.org
  Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped)
  In-Reply-To: <780310.1626963845@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox