pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)
Date: Fri, 20 Dec 2019 05:40:00 +0300
Message-ID: <f6b03b6e-59b7-1b99-0e8f-d42d72e35917@gmail.com> (raw)
In-Reply-To: <12599.1576786185@sss.pgh.pa.us>
References: <4741.1576684991@sss.pgh.pa.us>
	<b2cc98b1-0ba0-1358-572f-8a1a01a3880e@gmail.com>
	<26441.1576706955@sss.pgh.pa.us>
	<20191219.103948.2182167132387989763.horikyota.ntt@gmail.com>
	<d32a75e6-ba99-c95c-e475-1887c009d395@gmail.com>
	<32374.1576770248@sss.pgh.pa.us>
	<5c7eaa87-8670-2008-3a15-337c133c12c2@gmail.com>
	<12599.1576786185@sss.pgh.pa.us>

19.12.2019 23:09, Tom Lane wrote:
> Alexander Lakhin <exclusion@gmail.com> writes:
>> Maybe we should change the condition to 'if (stat(fileName, &st) != 0 &&
>> (err = GetLastError()) == ERROR_ACCESS_DENIED)' to avoid unnecessary
>> sleep with a loop iteration...
> Well, we have to loop back on file-not-found too ...
I think, if the file is not found on stat() we can safely return the
updated err (set errno with _dosmapper(err), to be exact). If we'll loop
back, we'll get the same err = GetLastError() after next CreateFile().
>> It seems that the check for ERROR_DELETE_PENDING was added to
>> pgwin32_safestat() blindly, the issue wasn't reproduced at that time:
>> https://www.postgresql.org/message-id/CAB7nPqRJV6trFta-Qzgi6j2feuYR2ZC%2BKHvWdHnbpDG2scTrxw%40mail.g...
> Hmm, makes one wonder whether that's actually live code.
I'll try to research this matter meantime.

Best regards,
Alexander





view thread (29+ messages)  latest in thread

Message-ID: <f6b03b6e-59b7-1b99-0e8f-d42d72e35917@gmail.com>
Permalink:  ../f6b03b6e-59b7-1b99-0e8f-d42d72e35917@gmail.com/
Also on:    postgresql.org/message-id/f6b03b6e-59b7-1b99-0e8f-d42d72e35917@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: exclusion@gmail.com, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)
  In-Reply-To: <f6b03b6e-59b7-1b99-0e8f-d42d72e35917@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox