From: Peter Eisentraut <peter@eisentraut.org>
To: Robert Haas <robertmhaas@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Cees van Zeeland <cees.van.zeeland@freedom.nl>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18362: unaccent rules and Old Greek text
Date: Wed, 15 May 2024 08:45:27 +0200
Message-ID: <fed622f0-b7bb-4294-a91b-02ccdd2bf54f@eisentraut.org> (raw)
In-Reply-To: <CA+TgmobZvFiTHhnO=jBqffMY=5OTB7R=jAkVRRR13yQG11UnvQ@mail.gmail.com>
References: <18362-be6d0cfe122b6354@postgresql.org>
<CA+hUKGLpoxTRryM1MxaHMpC1c5cxoKDm0iXfogQR9KGVUG=w9w@mail.gmail.com>
<ZdvLGeJ1BsXRkrdQ@paquier.xyz>
<d9875ca6-6438-4c52-adc1-5bc2ed28c362@freedom.nl>
<CA+hUKGK7OKZcCpvD92RyJtu6m_b6XRuZRNqSu_5Y3vHDn7KDpA@mail.gmail.com>
<CA+TgmobZvFiTHhnO=jBqffMY=5OTB7R=jAkVRRR13yQG11UnvQ@mail.gmail.com>
On 14.05.24 16:51, Robert Haas wrote:
> 1. The question of rule file load times seems like something that
> anyone who could compile PostgreSQL with and without a patch applied
> could test in under an hour. They could then report the results that
> they got, and people here could judge whether the resulting numbers
> are totally cool or very sad or something in between. Anyone willing
> to do that?
The rules are only loaded once on first use, right? I tested with
date; for x in $(seq 1 1000); do psql -X -c "select unaccent('foobar')"
-o /dev/null; done; date
and this had the same runtime (about 8 seconds here) with and without
the patch.
Btw., with the patch I get
WARNING: duplicate source strings, first one will be used
so it will need to adjustments in how the rules are produced.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter@eisentraut.org, robertmhaas@gmail.com, thomas.munro@gmail.com, cees.van.zeeland@freedom.nl, michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18362: unaccent rules and Old Greek text
In-Reply-To: <fed622f0-b7bb-4294-a91b-02ccdd2bf54f@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox