pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: feichanghong <feichanghong@qq.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
Date: Thu, 18 Sep 2025 14:15:15 +0800
Message-ID: <tencent_2E11BFCF657C758A7C04994072EC20382B0A@qq.com> (raw)
In-Reply-To: <CA+HiwqGb-B-5iBNh0eTVe9OgbZFTQi-jnErqN1LLq+W9MADdoA@mail.gmail.com>
References: <19056-a677cef9b54d76a0@postgresql.org>
	<CAApHDvoUketXqPj=1TpE81qPHvNj2fXRNomx2h7OkEm4nGqRcw@mail.gmail.com>
	<CAApHDvpNWPQU790AKFsMpSj4-fK1k7K78jigtPAXneiVT1_BBA@mail.gmail.com>
	<CA+HiwqG7Heq9WuzwtNixdqYEOAgcEgmx7dQGkGE0Bwt3v0EBXw@mail.gmail.com>
	<tencent_E6CAC49A0307E15909E4DD2DA3AA13E12305@qq.com>
	<CA+HiwqF+szimhYVh0F4vZJd0v6qViDs9zqvanjjsUCU8UjMNnQ@mail.gmail.com>
	<CA+HiwqGzUmLfMU3zoZWN2U31gsY57zULzds8MoX2uocd1yu_hg@mail.gmail.com>
	<CAApHDvpNdY9n7Q=-RJ1uYCuYQ1o7_uTbUYmQTQMAx5Rhh3Shug@mail.gmail.com>
	<1836971.1758168660@sss.pgh.pa.us>
	<CA+HiwqHsfgUxDHVEySwyd-CyTSOC1Nob9gSNfJ_3fZpxCnfX9A@mail.gmail.com>
	<CA+HiwqGb-B-5iBNh0eTVe9OgbZFTQi-jnErqN1LLq+W9MADdoA@mail.gmail.com>


> On Sep 18, 2025, at 14:09, Amit Langote <amitlangote09@gmail.com> wrote:
> 
> On Thu, Sep 18, 2025 at 1:56 PM Amit Langote <amitlangote09@gmail.com <mailto:amitlangote09@gmail.com>> wrote:
>> On Thu, Sep 18, 2025 at 1:11 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> 
>>> David Rowley <dgrowleyml@gmail.com> writes:
>>>> On Thu, 18 Sept 2025 at 15:37, Amit Langote <amitlangote09@gmail.com> wrote:
>>>>> +# Test that EState.es_part_prune_infos is properly set in EvalPlanQualStart()
>>>>> +# Bug #19056
>>> 
>>>> I don't think it's that useful to note down the bug number that caused
>>>> that test to be added.
>>> 
>>> We're inconsistent about whether we do that or not, but it's
>>> far from un-heard-of.  I just today pushed a patch in which
>>> I did mention the bug# in the test case [1], and I did so
>>> mostly because the adjacent test case had a similar comment.
>>> So I see no reason to object to Amit's usage.
>> 
>> I was just mimicking a few other "cf bug #" mentions in
>> eval-plan-qual.spec, but I'm fine to take it out if we'd prefer to
>> reduce that.  Git blame is enough.
>> 
>>>> I think it'd be better to write something like:
>>>> "Exercise run-time partition pruning code in an EPQ plan"
>>> 
>>> Not expressing an opinion about whether that's better or
>>> worse than Amit's lede.
>> 
>> What I added is:
>> 
>> # Test that EState.es_part_prune_infos is properly set in EvalPlanQualStart()
>> 
>> I'm fine to change the comment to David's suggestion since that makes
>> the test description less narrowly tied to one fix of one specific
>> issue in that path.
> 
> Patch updated.
> +# EState.es_part_prune_infos bug #19056

There is still bug #19056 here.

Best Regards,
Fei Changhong

view thread (21+ messages)  latest in thread

Message-ID: <tencent_2E11BFCF657C758A7C04994072EC20382B0A@qq.com>
Permalink:  ../tencent_2E11BFCF657C758A7C04994072EC20382B0A@qq.com/
Also on:    postgresql.org/message-id/tencent_2E11BFCF657C758A7C04994072EC20382B0A@qq.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: feichanghong@qq.com, amitlangote09@gmail.com, tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
  In-Reply-To: <tencent_2E11BFCF657C758A7C04994072EC20382B0A@qq.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox