pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix row filters with multiple publications
Date: Thu, 17 Mar 2022 22:11:20 +0100
Message-ID: <03bda6e8-6637-4cc5-0173-ac6c8cb19b65@enterprisedb.com> (raw)
In-Reply-To: <abd2cfb2-9297-1c6b-002e-329f27efc3b6@enterprisedb.com>
References: <E1nUsch-0008rQ-FW@gemulon.postgresql.org>
	<abd2cfb2-9297-1c6b-002e-329f27efc3b6@enterprisedb.com>

On 3/17/22 20:15, Tomas Vondra wrote:
> Hmm, this seems to have failed on wrasse [1], due to a timeout when
> waiting for tablesync to complete:
> 
> 2022-03-17 17:39:28.247 CET [19962:1] LOG:  logical replication table
> synchronization worker for subscription "sub2", table "tab1" has started
> 2022-03-17 17:39:28.258 CET [19964:1] LOG:  logical replication table
> synchronization worker for subscription "sub2", table "tab4" has started
> 
> In the previous runs this completed pretty much immediately (less than a
> second), but this time the workers got stuck, so the script keeps
> looping on the $synced_query. There's nothing in the log, so either it's
> some sort of lock wait or infinite loop.
> 
> However, this fails in 013_partition.sql, which was not modified in this
> commit. And there have been multiple successful runs since it was
> modified (in c91f71b9dc). So it's not clear if this is a pre-existing
> issue and we just happened to hit it now, or maybe it's introduced by
> either c91f71b9dc or 5a07966225. But neither of these commits touched
> tablesync at all, so I'm puzzled how could it happen.
> 

And sure enough - now it passed on wrasse, while lapwing failed with
exactly the same symptoms. Clearly some sort of race condition, but I've
been unable to reproduce that :-(

I'll try on my rpi4 once I get back home next week, but maybe we could
try reproducing this on one of the machines that triggered this so far.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (4+ messages)  latest in thread

Message-ID: <03bda6e8-6637-4cc5-0173-ac6c8cb19b65@enterprisedb.com>
Permalink:  ../03bda6e8-6637-4cc5-0173-ac6c8cb19b65@enterprisedb.com/
Also on:    postgresql.org/message-id/03bda6e8-6637-4cc5-0173-ac6c8cb19b65@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, tomas.vondra@postgresql.org
  Subject: Re: pgsql: Fix row filters with multiple publications
  In-Reply-To: <03bda6e8-6637-4cc5-0173-ac6c8cb19b65@enterprisedb.com>
  References: <E1nUsch-0008rQ-FW@gemulon.postgresql.org> <abd2cfb2-9297-1c6b-002e-329f27efc3b6@enterprisedb.com> <03bda6e8-6637-4cc5-0173-ac6c8cb19b65@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox