From: Petr Jelinek <petr.jelinek@enterprisedb.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Markus Wanner <markus.wanner@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
Date: Thu, 7 Apr 2022 20:07:17 +0200
Message-ID: <051E2C40-14DF-4AE4-9273-A9A42CDAB5C2@enterprisedb.com> (raw)
In-Reply-To: <CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com>
References: <E1nXTCX-001DGF-R0@gemulon.postgresql.org>
<a7880f4d-1d74-582a-ada7-dad168d046d1@enterprisedb.com>
<CA+TgmoaVwQj_nG-jPB8O=t8=h-QBoF2U+tKviv8BT8unfTEZiw@mail.gmail.com>
<2358496.1649168259@sss.pgh.pa.us>
<CA+Tgmoao-kUD9c5nG5sub3F7tbo39+cdr8jKaOVEs_1aBWcJ3Q@mail.gmail.com>
> On 7. 4. 2022, at 17:19, Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Tue, Apr 5, 2022 at 10:17 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> What I think you need to do is:
>>
>> 1. In the back branches, revert delayChkpt to its previous type and
>> semantics. Squeeze a separate delayChkptEnd bool in somewhere
>> (you can't change the struct size either ...).
>>
>> 2. In HEAD, rename the field to something like delayChkptFlags,
>> to ensure that any code touching it has to be inspected and updated.
>
> Here are patches for master and v14 to do things this way. Comments?
Yeah I think this should do it (compilers should warn on master even without the rename, but who notices that right? :) )
Thanks,
Petr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: petr.jelinek@enterprisedb.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org, horikyota.ntt@gmail.com
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
In-Reply-To: <051E2C40-14DF-4AE4-9273-A9A42CDAB5C2@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox