pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Daniel Gustafsson <daniel@yesql.se>
To: Daniel Gustafsson <dgustafsson@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove the adminpack contrib extension
Date: Mon, 4 Mar 2024 14:01:03 +0100
Message-ID: <0CFB76D0-0510-48B2-9916-1199F93BC28C@yesql.se> (raw)
In-Reply-To: <E1rh6j5-0021w3-GX@gemulon.postgresql.org>
References: <E1rh6j5-0021w3-GX@gemulon.postgresql.org>

> On 4 Mar 2024, at 12:43, Daniel Gustafsson <dgustafsson@postgresql.org> wrote:
> 
> Remove the adminpack contrib extension

The pg_upgrade Xversion test on crake failed on this, I'm trying to reproduce
the cross-version test locally to verify the below diff but it's right now
failing on an unrelated thing.  If anyone has a working setup locally to test I
would love the below taken for a spin against something in 16->12.

inline patch 1: src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm (+10/-0 lines) download inline-1.patch
diff --git a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
index c0da0aaff8..8dc1a65e3d 100644
--- a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
+++ b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm
@@ -106,6 +106,16 @@ sub adjust_database_contents
 			'drop extension if exists test_ext7');
 	}
 
+	# we removed the adminpack extension in v17
+	if ($old_version >= 12 && $old_version < 17)
+	{
+		_add_st($result, 'regression',
+			'drop extension if exists adminpack');
+		_add_st($result, 'postgres',
+			'drop database contrib_regression_adminpack');
+		delete($dbnames{'contrib_regression_adminpack'});
+	}
+
 	# we removed this test-support function in v17
 	if ($old_version >= 15 && $old_version < 17)
 	{

--
Daniel Gustafsson

view thread (7+ messages)  latest in thread

Message-ID: <0CFB76D0-0510-48B2-9916-1199F93BC28C@yesql.se>
Permalink:  ../0CFB76D0-0510-48B2-9916-1199F93BC28C@yesql.se/
Also on:    postgresql.org/message-id/0CFB76D0-0510-48B2-9916-1199F93BC28C@yesql.se

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: daniel@yesql.se, dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove the adminpack contrib extension
  In-Reply-To: <0CFB76D0-0510-48B2-9916-1199F93BC28C@yesql.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox