pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Date: Sun, 17 Apr 2022 10:56:08 -0400
Message-ID: <0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net> (raw)
In-Reply-To: <YluU3C4i8sHoVeOQ@paquier.xyz>
References: <E1mfuYK-0004Bn-7O@gemulon.postgresql.org>
	<3385143.1649353230@sss.pgh.pa.us>
	<20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de>
	<3386734.1649354265@sss.pgh.pa.us>
	<20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de>
	<4015413.1649454951@sss.pgh.pa.us>
	<20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de>
	<CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com>
	<YlT23IvsXkGuLzFi@paquier.xyz>
	<CA+hUKGL=BN-Fk8JbbWGtL2HK1tJxQRg+4Czs76v+bSN7Si0A5w@mail.gmail.com>
	<YluU3C4i8sHoVeOQ@paquier.xyz>


On 2022-04-17 Su 00:17, Michael Paquier wrote:
>> Since it's quite painful to run TAP tests under valgrind, I found a
>> place to stick a plain old sleep to repro these problems:
> Actually, I am wondering how you are patching Cluster.pm to do that.



I don't really think it's Cluster.pm's business to deal with that. It
takes an install path as given either explicitly or implicitly.

It shouldn't be too hard to get Makefile.global to install valgrind
wrappers into the tmp_install/bin directory.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (20+ messages)  latest in thread

Message-ID: <0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net>
Permalink:  ../0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net/
Also on:    postgresql.org/message-id/0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, michael@paquier.xyz, thomas.munro@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
  In-Reply-To: <0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net>
  References: <E1mfuYK-0004Bn-7O@gemulon.postgresql.org> <3385143.1649353230@sss.pgh.pa.us> <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de> <3386734.1649354265@sss.pgh.pa.us> <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de> <4015413.1649454951@sss.pgh.pa.us> <20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de> <CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com> <YlT23IvsXkGuLzFi@paquier.xyz> <CA+hUKGL=BN-Fk8JbbWGtL2HK1tJxQRg+4Czs76v+bSN7Si0A5w@mail.gmail.com> <YluU3C4i8sHoVeOQ@paquier.xyz> <0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox