From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Date: Tue, 19 Apr 2022 11:33:25 +0900
Message-ID: <Yl4fdcOqQhAgB5Sa@paquier.xyz> (raw)
In-Reply-To: <CA+hUKGJYk56m7sycB4KhrEaYRnTYN-P3jYaXNbMGjsTicEHn6A@mail.gmail.com>
References: <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de>
<4015413.1649454951@sss.pgh.pa.us>
<20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de>
<CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com>
<YlT23IvsXkGuLzFi@paquier.xyz>
<CA+hUKGL=BN-Fk8JbbWGtL2HK1tJxQRg+4Czs76v+bSN7Si0A5w@mail.gmail.com>
<YluU3C4i8sHoVeOQ@paquier.xyz>
<0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net>
<YlynfULh/svXYbfT@paquier.xyz>
<CA+hUKGJYk56m7sycB4KhrEaYRnTYN-P3jYaXNbMGjsTicEHn6A@mail.gmail.com>
On Tue, Apr 19, 2022 at 09:45:11AM +1200, Thomas Munro wrote:
> Delayed response to the question on how I did that, because it was a 4
> day weekend down here and I got distracted by sunshine...
Happy Easter.
> I think that sort of thing actually worked when I tried it on a
> beefier workstation, but it sent my Thinkpad that "only" has a 16GB of
> RAM into some kind of death spiral. The way I succeeded was indeed
> using a wrapper script, based on a suggestion from Andres, my
> kludgy-hardcoded-path-assuming implementation of which looked like:
>
> Yeah, it might be quite neat to find a tool-supported way to do that.
Thanks for the details. I feared that it was something like that for
the backend. At least that's better than having valgrind spawn all
the processes kicked by the make command. :/
> Tangentially, I'd also like to look into making
> PostgreSQL-under-Valgrind work on FreeBSD and macOS, which didn't work
> last time I tried it for reasons that might, I hope, have been fixed
> on the Valgrind side by now.
Okay.
As a side note, skink has cooled down since acf1dd4, and did not
complain either after the additions of e61efaf and 1a8b110.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, thomas.munro@gmail.com, andrew@dunslane.net, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
In-Reply-To: <Yl4fdcOqQhAgB5Sa@paquier.xyz>
References: <20220407181202.7xa573u6e2z5dbdz@alap3.anarazel.de> <4015413.1649454951@sss.pgh.pa.us> <20220409005910.alw46xqmmgny2sgr@alap3.anarazel.de> <CA+hUKGJ-gvLg9vJgMvu62XW-Nsb2Hf40DvqmKdusVeJ7KV-crA@mail.gmail.com> <YlT23IvsXkGuLzFi@paquier.xyz> <CA+hUKGL=BN-Fk8JbbWGtL2HK1tJxQRg+4Czs76v+bSN7Si0A5w@mail.gmail.com> <YluU3C4i8sHoVeOQ@paquier.xyz> <0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net> <YlynfULh/svXYbfT@paquier.xyz> <CA+hUKGJYk56m7sycB4KhrEaYRnTYN-P3jYaXNbMGjsTicEHn6A@mail.gmail.com> <Yl4fdcOqQhAgB5Sa@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox