From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-committers@postgresql.org, PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Record full paths of programs sought by "configure".
Date: Mon, 07 Aug 2017 15:36:38 -0400
Message-ID: <10269.1502134598@sss.pgh.pa.us> (raw)
In-Reply-To: <90c39664-ec60-77dc-9f1b-21e8fa7b864c@2ndQuadrant.com>
References: <E1dcE5n-0005Sk-UE@gemulon.postgresql.org>
<d6ca14d4-a475-6496-48b6-d9f58b29a875@2ndQuadrant.com>
<7295.1502133694@sss.pgh.pa.us>
<90c39664-ec60-77dc-9f1b-21e8fa7b864c@2ndQuadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 08/07/2017 03:21 PM, Tom Lane wrote:
>> I'm confused. AFAIK, that commit did not change which "prove" would
>> be used --- at least not unless you change PATH between configure and
>> make. It only changed how specifically that program would be named in
>> Makefile.global. Please clarify how that broke anything.
> That's exactly what we do. See
> <https://github.com/PGBuildFarm/client-code/blob/master/run_build.pl; at
> line 1649.
My goodness, that's ugly. Is it really better than injecting
"PROVE=prove"? (I'd suggest saying that to configure, not make,
so that the configure log bears some resemblance to what you
want done.)
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Record full paths of programs sought by "configure".
In-Reply-To: <10269.1502134598@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox