From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Improve internationalization of messages involving type names
Date: Mon, 28 Mar 2016 14:06:07 -0400
Message-ID: <10551.1459188367@sss.pgh.pa.us> (raw)
In-Reply-To: <E1akaul-0007ni-Rq@gemulon.postgresql.org>
References: <E1akaul-0007ni-Rq@gemulon.postgresql.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Also, change them all to use the same quoting convention, namely that
> the function name is not to be quoted but the type name is. (I'm not
> quite sure why this is so, but it's the clear majority.)
Actually, I think the general convention is to NOT quote type names
in error messages. Certainly that's so when using format_type_be()
to produce a name for a not-known-at-compile-time type. I would
argue that these messages should be written to look the same as if
format_type_be() had been used, and that would mean leaving off
the quotes.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org
Subject: Re: pgsql: Improve internationalization of messages involving type names
In-Reply-To: <10551.1459188367@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox