pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Date: Tue, 19 Jul 2022 09:45:52 -0400
Message-ID: <1057666.1658238352@sss.pgh.pa.us> (raw)
In-Reply-To: <20220719131801.xltj7tupafzkj5dx@alvherre.pgsql>
References: <20220719131801.xltj7tupafzkj5dx@alvherre.pgsql>

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2022-Jul-19, Pavel Stehule wrote:
>> Unfortunately, this commit definitely breaks plpgsql_check. Can the
>> following routines be visible?

> Do you just need to send a patch to add an exports.txt file to
> src/pl/plpgsql/src/ for these functions?

The precedent of plpython says that PGDLLEXPORT markers are sufficient.
But yeah, we need a list of exactly which functions need to be
re-exposed.  I imagine pldebugger has its own needs.

			regards, tom lane





view thread (27+ messages)  latest in thread

Message-ID: <1057666.1658238352@sss.pgh.pa.us>
Permalink:  ../1057666.1658238352@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1057666.1658238352@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, pavel.stehule@gmail.com, andres@anarazel.de
  Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
  In-Reply-To: <1057666.1658238352@sss.pgh.pa.us>
  References: <20220719131801.xltj7tupafzkj5dx@alvherre.pgsql> <1057666.1658238352@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox