From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add option to use ICU as global locale provider
Date: Fri, 18 Mar 2022 11:07:04 -0400
Message-ID: <1069623.1647616024@sss.pgh.pa.us> (raw)
In-Reply-To: <20220318031244.tu3wwlyxxabzq3iu@jrouhaud>
References: <E1nUnH5-0006aR-MX@gemulon.postgresql.org>
<YjPn5+Y9Gj58PlEW@paquier.xyz>
<20220318031244.tu3wwlyxxabzq3iu@jrouhaud>
Julien Rouhaud <rjuju123@gmail.com> writes:
> That being said, we could save the result and explicitly close the collator.
> That wouldn't make much difference in initdb (but may be a bit cleaner), but I
> see that there's a similar coding in createdb(), which seems like it could leak
> some memory according to ucol_close man page.
FYI, I verified using valgrind that (as of HEAD) there is a leak
when creating a database with ICU collation that doesn't appear
when creating one with libc collation. It's not a lot, a few
hundred bytes per iteration, but it's there.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, rjuju123@gmail.com, michael@paquier.xyz, peter@eisentraut.org
Subject: Re: pgsql: Add option to use ICU as global locale provider
In-Reply-To: <1069623.1647616024@sss.pgh.pa.us>
References: <E1nUnH5-0006aR-MX@gemulon.postgresql.org> <YjPn5+Y9Gj58PlEW@paquier.xyz> <20220318031244.tu3wwlyxxabzq3iu@jrouhaud> <1069623.1647616024@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox