From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix incorrect format placeholder.
Date: Tue, 09 Nov 2021 01:06:26 -0500
Message-ID: <1103686.1636437986@sss.pgh.pa.us> (raw)
In-Reply-To: <YYoJYO475dsqYhta@paquier.xyz>
References: <E1mkANl-0001P8-Ur@gemulon.postgresql.org>
<YYnU5x3OQI73sgoE@paquier.xyz>
<1100878.1636435176@sss.pgh.pa.us>
<YYoJYO475dsqYhta@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Nov 09, 2021 at 12:19:36AM -0500, Tom Lane wrote:
>> Umm ... florican and dangomushi spotted it. Maybe we need a 32-bit
>> machine with -Werror?
> Indeed, I can see it in the logs of dangomushi. I could add a -Werror
> there, but there are also a bunch of warnings generated by plperl.
Yeah, we had complaints before about -Wcompound-token-split-by-macro
warnings.
> I'd rather keep --with-perl and clang, and there seems to be a fix
> regarding that stuff in upstream:
> https://www.nntp.perl.org/group/perl.perl5.changes/2021/07/msg57758.html
I figured the Perl guys would do something about it, but it will be a
very long time before that propagates everywhere. Maybe we should
teach configure to add -Wno-compound-token-split-by-macro? By my
count there are now five buildfarm members besides dangomushi that
are producing these warnings, and I think the number is going to
go up before it goes down.
(Meanwhile, I guess I could enable -Werror on florican.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix incorrect format placeholder.
In-Reply-To: <1103686.1636437986@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox