From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove unneeded defines from pg_config.h.in
Date: Sun, 04 Jan 2026 19:41:23 -0500
Message-ID: <1193764.1767573683@sss.pgh.pa.us> (raw)
In-Reply-To: <E1vcYUU-004XVb-1O@gemulon.postgresql.org>
References: <E1vcYUU-004XVb-1O@gemulon.postgresql.org>
Michael Paquier <michael@paquier.xyz> writes:
> Remove unneeded defines from pg_config.h.in
> This commit removes HAVE_ATOMIC_H and HAVE_MBARRIER_H from
> pg_config.h.in, cleanup that could have been done in 25f36066dd2a.
This patch is not okay. pg_config.h.in is a generated file and
hand modifications in it will not do.
If we don't need these symbols anymore, the right fix is to remove
the probes for these headers in the autoconf and meson scripts.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove unneeded defines from pg_config.h.in
In-Reply-To: <1193764.1767573683@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox