From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use that in li
Date: Fri, 28 Sep 2018 09:51:51 -0400
Message-ID: <11d432a5-659e-81da-3722-513d039515e1@2ndQuadrant.com> (raw)
In-Reply-To: <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
References: <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
On 09/27/2018 11:23 AM, Tom Lane wrote:
> Build src/port files as a library with -fPIC, and use that in libpq.
>
> libpq and ecpg need shared-library-friendly versions of assorted src/port/
> and src/common/ modules. Up to now, they got those by symlinking the
> individual source files and compiling them locally. That's baroque, and a
> pain to maintain, and it results in some amount of duplicated compile work.
> It might've made sense when only a couple of files were needed, but the
> list has grown and grown and grown :-(
>
> It makes more sense to have the originating directory build a third variant
> of libpgport.a/libpgcommon.a containing modules built with $(CFLAGS_SL),
> and just link that into the shared library. Unused files won't get linked,
> so the end result should be the same.
>
> This patch makes a down payment on that idea by having src/port/ build
> such a library and making libpq use it. If the buildfarm doesn't expose
> fatal problems with the approach, I'll extend it to the other cases.
>
Looks like we have a bunch of failures, including prairiedog.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use that in li
In-Reply-To: <11d432a5-659e-81da-3722-513d039515e1@2ndQuadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox