pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: In the pg_upgrade test suite, don't write to src/test/regress.
14+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2019-05-19 ae35e1c9d7 9518978e22 4796c5ec47 2604751c73 e0a39a1d9a Revert "In the pg_upgrade test suite, don't write to src/test/regress."
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-19 21:40 Noah Misch <noah@leadboat.com>
2019-05-19 21:53 ` Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Tom Lane <tgl@sss.pgh.pa.us>
2019-05-19 21:54 ` Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Andres Freund <andres@anarazel.de>
0 siblings, 2 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-19 21:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released forty-five days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bd1592e8570282b1650af6b8eede0016496daecd
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 12 ++++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 18 +++++++++++++++++-
5 files changed, 38 insertions(+), 10 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
2019-05-19 21:40 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
@ 2019-05-19 21:53 ` Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 0 replies; 14+ messages in thread
From: Tom Lane @ 2019-05-19 21:53 UTC (permalink / raw)
To: Noah Misch <noah@leadboat.com>; +Cc: pgsql-committers@lists.postgresql.org
Noah Misch <noah@leadboat.com> writes:
> In the pg_upgrade test suite, don't write to src/test/regress.
buildfarm is pretty unimpressed :-(
regards, tom lane
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
2019-05-19 21:40 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
@ 2019-05-19 21:54 ` Andres Freund <andres@anarazel.de>
2019-05-19 22:14 ` Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Andres Freund <andres@anarazel.de>
2019-05-19 22:19 ` Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 2 replies; 14+ messages in thread
From: Andres Freund @ 2019-05-19 21:54 UTC (permalink / raw)
To: Noah Misch <noah@leadboat.com>; +Cc: pgsql-committers@lists.postgresql.org
Hi,
On 2019-05-19 21:40:43 +0000, Noah Misch wrote:
> In the pg_upgrade test suite, don't write to src/test/regress.
>
> When this suite runs installcheck, redirect file creations from
> src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
> race condition in "make -j check-world". If the pg_upgrade suite wrote
> to a given src/test/regress/results file in parallel with the regular
> src/test/regress invocation writing it, a test failed spuriously. Even
> without parallelism, in "make -k check-world", the suite finishing
> second overwrote the other's regression.diffs. This revealed test
> "largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
>
> Buildfarm client REL_10, released forty-five days ago, supports saving
> regression.diffs from its new location. When an older client reports a
> pg_upgradeCheck failure, it will no longer include regression.diffs.
> Back-patch to 9.5, where pg_upgrade moved to src/bin.
>
> Reviewed by Andrew Dunstan.
The buildfarm decidedly is not a fan of this:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spurfowl&dt=2019-05-19%2021%3A43%3A32
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
2019-05-19 21:40 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-19 21:54 ` Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Andres Freund <andres@anarazel.de>
@ 2019-05-19 22:14 ` Andres Freund <andres@anarazel.de>
1 sibling, 0 replies; 14+ messages in thread
From: Andres Freund @ 2019-05-19 22:14 UTC (permalink / raw)
To: Noah Misch <noah@leadboat.com>; +Cc: pgsql-committers@lists.postgresql.org
Hi,
On 2019-05-19 14:54:50 -0700, Andres Freund wrote:
> On 2019-05-19 21:40:43 +0000, Noah Misch wrote:
> > In the pg_upgrade test suite, don't write to src/test/regress.
>
> The buildfarm decidedly is not a fan of this:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spurfowl&dt=2019-05-19%2021%3A43%3A32
And now also a different type of failure:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory&dt=2019-05-19%2021%3A45%3A26
Last file mtime in snapshot: Sun May 19 21:36:44 2019 GMT
===================================================
Can't locate object method "installcheck_internal" via package "serial" (perhaps you forgot to load "serial"?) at vcregress.pl line 105.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
2019-05-19 21:40 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-19 21:54 ` Re: pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Andres Freund <andres@anarazel.de>
@ 2019-05-19 22:19 ` Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 0 replies; 14+ messages in thread
From: Tom Lane @ 2019-05-19 22:19 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Noah Misch <noah@leadboat.com>; pgsql-committers@lists.postgresql.org
Andres Freund <andres@anarazel.de> writes:
> The buildfarm decidedly is not a fan of this:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spurfowl&dt=2019-05-19%2021%3A43%3A32
Also, dory is showing a different failure mode, in which it's not even
getting to the pg_upgrade test:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory&dt=2019-05-19%2021%3A45%3A26
The regular installcheck test is dying with
Can't locate object method "installcheck_internal" via package "serial" (perhaps you forgot to load "serial"?) at vcregress.pl line 105.
Seems like some kind of syntax problem in the patch's change to
vcregress.pl? I'm not enough of a Perl guy to diagnose it.
regards, tom lane
^ permalink raw reply [nested|flat] 14+ messages in thread
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-19 21:40 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-19 21:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released forty-five days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d08d880ab41afff57280e69b89144076ae068999
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 12 ++++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 18 +++++++++++++++++-
5 files changed, 38 insertions(+), 10 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-19 21:40 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-19 21:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released forty-five days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/422584caf32fa0477272447fd3f3851211310a6e
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 12 ++++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 18 +++++++++++++++++-
5 files changed, 38 insertions(+), 10 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-19 21:40 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-19 21:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released forty-five days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4f4b2d4161b1406f6f37c164cf2f383d2ec7a684
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 12 ++++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 18 +++++++++++++++++-
5 files changed, 38 insertions(+), 10 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-19 21:40 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-19 21:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released forty-five days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e00b5f090fa04656dd1929786720f500741efbac
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 12 ++++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 18 +++++++++++++++++-
5 files changed, 38 insertions(+), 10 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-28 20:09 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-28 20:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released fifty-four days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed (in earlier versions) by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/40b132c1afbb4b1494aa8e48cc35ec98d2b90777
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 11 +++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 21 ++++++++++++++++++---
5 files changed, 38 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-28 20:09 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-28 20:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released fifty-four days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed (in earlier versions) by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/88a0e3daf862def3503a69f89bc9eeecb7d73736
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 11 +++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 21 ++++++++++++++++++---
5 files changed, 38 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-28 20:09 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-28 20:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released fifty-four days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed (in earlier versions) by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c44e9bc3a10f8c6dff07db355375339d7a6db24b
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 11 +++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 21 ++++++++++++++++++---
5 files changed, 38 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-28 20:09 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-28 20:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released fifty-four days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed (in earlier versions) by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5e89aa021e00a5a3c3b0475eaa232a1e62cb1061
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 11 +++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 21 ++++++++++++++++++---
5 files changed, 38 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* pgsql: In the pg_upgrade test suite, don't write to src/test/regress.
@ 2019-05-28 20:09 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 14+ messages in thread
From: Noah Misch @ 2019-05-28 20:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released fifty-four days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed (in earlier versions) by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5c0fee0be2f64439149a37bc4bc4f44b1fcdcda8
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 11 +++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 21 ++++++++++++++++++---
5 files changed, 38 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
end of thread, other threads:[~2019-05-28 20:09 UTC | newest]
Thread overview: 14+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-05-19 21:40 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-19 21:53 ` Tom Lane <tgl@sss.pgh.pa.us>
2019-05-19 21:54 ` Andres Freund <andres@anarazel.de>
2019-05-19 22:14 ` Andres Freund <andres@anarazel.de>
2019-05-19 22:19 ` Tom Lane <tgl@sss.pgh.pa.us>
2019-05-19 21:40 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-19 21:40 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-19 21:40 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-19 21:40 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-28 20:09 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-28 20:09 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-28 20:09 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-28 20:09 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
2019-05-28 20:09 pgsql: In the pg_upgrade test suite, don't write to src/test/regress. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox