pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: pgstat: run pgindent on pgstat.c/h.
Date: Sat, 19 Mar 2022 15:52:15 -0400
Message-ID: <1340428.1647719535@sss.pgh.pa.us> (raw)
In-Reply-To: <20220319194230.3lf5ghffngwxwrrf@alap3.anarazel.de>
References: <E1nVe4j-000SIV-55@gemulon.postgresql.org>
	<CAH2-WzmNWa8M9nXyA4inC+ehgdPZO9BL7Je91Q4YsetXp40w3A@mail.gmail.com>
	<20220319192715.tymn3rrg6qd6va5y@alap3.anarazel.de>
	<CAH2-WzmuFCFg+FX31Z_Qz1cxdzV0RDK491fgB-hg-=4DJsAdww@mail.gmail.com>
	<20220319194230.3lf5ghffngwxwrrf@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-03-19 12:36:29 -0700, Peter Geoghegan wrote:
>> Ideally there would be some kind of reminder built into the
>> pgindent tooling to make it less likely.

> I think a lot of pgindent runs are just to reindent changes during
> development, so that'd probably just join all the other stuff we learn to
> ignore :)

Yeah ... you can't do anything about it at the time you run pgindent,
because you don't yet have the commit hash.  So I don't see that such
a reminder will help much.  The pgindent/README file does mention
that you ought to do this, so anyone following that recipe will
get it right.

			regards, tom lane





view thread (7+ messages)

Message-ID: <1340428.1647719535@sss.pgh.pa.us>
Permalink:  ../1340428.1647719535@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1340428.1647719535@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pg@bowt.ie
  Subject: Re: pgsql: pgstat: run pgindent on pgstat.c/h.
  In-Reply-To: <1340428.1647719535@sss.pgh.pa.us>
  References: <E1nVe4j-000SIV-55@gemulon.postgresql.org> <CAH2-WzmNWa8M9nXyA4inC+ehgdPZO9BL7Je91Q4YsetXp40w3A@mail.gmail.com> <20220319192715.tymn3rrg6qd6va5y@alap3.anarazel.de> <CAH2-WzmuFCFg+FX31Z_Qz1cxdzV0RDK491fgB-hg-=4DJsAdww@mail.gmail.com> <20220319194230.3lf5ghffngwxwrrf@alap3.anarazel.de> <1340428.1647719535@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox