From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove check for accept() argument types
Date: Wed, 10 Nov 2021 10:41:28 -0500
Message-ID: <1440792.1636558888@sss.pgh.pa.us> (raw)
In-Reply-To: <E1mkSdp-0008FH-7Y@gemulon.postgresql.org>
References: <E1mkSdp-0008FH-7Y@gemulon.postgresql.org>
Peter Eisentraut <peter@eisentraut.org> writes:
> Remove check for accept() argument types
Early returns from the buildfarm are
gaur | 2021-11-09 16:55:58 | auth.c:3235:17: warning: pointer targets in passing argument 6 of 'recvfrom' differ in signedness
gaur | 2021-11-09 16:55:58 | pqcomm.c:722:9: warning: pointer targets in passing argument 3 of 'accept' differ in signedness
gaur | 2021-11-09 16:55:58 | pqcomm.c:743:6: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness
gaur | 2021-11-09 16:55:58 | pgstat.c:483:39: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness
gaur | 2021-11-09 16:55:58 | pgstat.c:630:9: warning: pointer targets in passing argument 5 of 'getsockopt' differ in signedness
gaur | 2021-11-09 16:55:58 | fe-connect.c:2760:11: warning: pointer targets in passing argument 5 of 'getsockopt' differ in signedness
gaur | 2021-11-09 16:55:58 | fe-connect.c:2788:9: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness
Right offhand I don't see any other animals complaining.
May I suggest that "unsigned int" would be a better choice
than "int" for socklen_t?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove check for accept() argument types
In-Reply-To: <1440792.1636558888@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox