pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Alexander Korotkov <akorotkov@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
Date: Thu, 11 Feb 2021 13:46:07 -0500
Message-ID: <1477976.1613069167@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfdvmNwqEZajGsERi6y2Q7DRN892dPDt+WPTZqqsWDTFTZw@mail.gmail.com>
References: <E1l6Jjn-0000kp-75@gemulon.postgresql.org>
	<37bb56a0-391d-759d-771b-9c1d8c15a84b@iki.fi>
	<3293925.1612163110@sss.pgh.pa.us>
	<CAPpHfdsne3=T=fMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w@mail.gmail.com>
	<CAPpHfdu8Jh0tySa50Zhkyg6gMvi2pQFdHAMiF+UkZNqsDLwTQw@mail.gmail.com>
	<475514.1612745257@sss.pgh.pa.us>
	<477102.1612747200@sss.pgh.pa.us>
	<628089.1612802981@sss.pgh.pa.us>
	<CAPpHfdvmNwqEZajGsERi6y2Q7DRN892dPDt+WPTZqqsWDTFTZw@mail.gmail.com>

Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Mon, Feb 8, 2021 at 7:49 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Ugh, no it isn't: even pretty recent clang releases only define
>> __GNUC__ as 4.  It looks like we need a separate test on clang's
>> version.  I looked at their version history and sanitizers seem
>> to have come in around clang 7, so I propose the attached (where
>> I worked a bit harder on the comment, too).

> Looks good to me.  Thank you for revising!

Were you going to push this, or did you expect me to?

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <1477976.1613069167@sss.pgh.pa.us>
Permalink:  ../1477976.1613069167@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1477976.1613069167@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, aekorotkov@gmail.com, hlinnaka@iki.fi, akorotkov@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)
  In-Reply-To: <1477976.1613069167@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox