From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove check for accept() argument types
Date: Fri, 12 Nov 2021 09:21:05 -0500
Message-ID: <1683239.1636726865@sss.pgh.pa.us> (raw)
In-Reply-To: <3863895c-d40b-4154-de8f-4961386b2515@enterprisedb.com>
References: <E1mkSdp-0008FH-7Y@gemulon.postgresql.org>
<1440792.1636558888@sss.pgh.pa.us>
<3863895c-d40b-4154-de8f-4961386b2515@enterprisedb.com>
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 10.11.21 16:41, Tom Lane wrote:
>> May I suggest that "unsigned int" would be a better choice
>> than "int" for socklen_t?
> I have been waiting for a few more buildfarm members to finish (mainly
> the other AIX and HPUX instances), but they appear to be on strike right
> now.
I waited to see one of the AIX 7.1 instances report, and it does have
socklen_t. So the only old buildfarm members that any uncertainty
remains about are the HPUX 11 ones. Probably those have socklen_t;
but if they don't, given that we know HPUX 10 wants "unsigned int",
it seems certain that 11 would too. So I went ahead and pushed that
change yesterday.
> What does the man page say the correct type
> would be? size_t?
The machine's not booted up right now :-(. But I'm pretty sure we
shouldn't consider using size_t here, as it's not real clear that that
couldn't be 64 bits on any affected platforms. Your previous research
said that the desired type is 32 bits on all such platforms, so I think
that "int" is correct; we need only debate signedness.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove check for accept() argument types
In-Reply-To: <1683239.1636726865@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox