From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Date: Wed, 20 Jul 2022 10:09:01 -0400
Message-ID: <1697006.1658326141@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoaDE=vypmASyWwxV4jTJ0r81f2OtotkF61aZLjygMzEcw@mail.gmail.com>
References: <20220720090247.kjqkzxh43vjaw45y@alvherre.pgsql>
<1691356.1658324330@sss.pgh.pa.us>
<CA+TgmoaDE=vypmASyWwxV4jTJ0r81f2OtotkF61aZLjygMzEcw@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Jul 20, 2022 at 9:39 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> ISTM that a comment pointing out that the functions marked PGDLLEXPORT
>> are meant to be externally accessible should be sufficient.
> The name PGDLLEXPORT is actually slightly misleading, now, because
> there's no longer anything about it that is specific to DLLs.
True, but the mess of changing it seems to outweigh any likely clarity
gain. As long as there's adequate commentary about what it means,
I'm okay with the existing naming.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, alvherre@alvh.no-ip.org, andres@anarazel.de, pavel.stehule@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
In-Reply-To: <1697006.1658326141@sss.pgh.pa.us>
References: <20220720090247.kjqkzxh43vjaw45y@alvherre.pgsql> <1691356.1658324330@sss.pgh.pa.us> <CA+TgmoaDE=vypmASyWwxV4jTJ0r81f2OtotkF61aZLjygMzEcw@mail.gmail.com> <1697006.1658326141@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox