pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@lists.postgresql.org, Craig Ringer <craig.ringer@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Thu, 07 Oct 2021 15:44:48 -0400
Message-ID: <173186.1633635888@sss.pgh.pa.us> (raw)
In-Reply-To: <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se>
References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org>
	<150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se>
	<161525.1633632402@sss.pgh.pa.us>
	<162421.1633633360@sss.pgh.pa.us>
	<12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se>

[ cc'ing Craig and Noah, as author/committer of the existing text ]

Daniel Gustafsson <daniel@yesql.se> writes:
> On 7 Oct 2021, at 21:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> BTW, looking at that a second time, I wonder if that advice is
>> really of any use.

> Yeah, I would have to agree.  Reading that again I think what it perhaps should
> be saying is that 5.8.3 is the Perl API level that the testcode must conform
> to, but they should run with basically whichever recent Perl you have handy as
> long as the required modules are installed.  Not that we expect developers to
> run 5.8.3 when executing TAP tests.

Yeah.  I propose that what might be more useful than the existing last
section of src/test/perl/README is something along the lines of:

  Avoid using any bleeding-edge Perl features.  We have buildfarm
  animals running Perl versions as old as 5.8.3, so your tests will
  be expected to pass on that.

  Also, do not use any non-core Perl modules except IPC::Run.
  Or, if you must do so for a particular test, arrange to skip
  the test when the needed module isn't present.


			regards, tom lane





view thread (33+ messages)  latest in thread

Message-ID: <173186.1633635888@sss.pgh.pa.us>
Permalink:  ../173186.1633635888@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/173186.1633635888@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, craig.ringer@enterprisedb.com, noah@leadboat.com
  Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
  In-Reply-To: <173186.1633635888@sss.pgh.pa.us>
  References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org> <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox