From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
Date: Tue, 28 Aug 2018 17:08:25 -0400
Message-ID: <17758.1535490505@sss.pgh.pa.us> (raw)
In-Reply-To: <12438.1535488750@sss.pgh.pa.us>
References: <E1fudM8-0000af-Lm@gemulon.postgresql.org>
<12438.1535488750@sss.pgh.pa.us>
I wrote:
> Digging, this is because the "make check" processing isn't actually
> installing oid2name (resp. vacuumlo) into the temp installation tree :-(.
>
> I don't think this is the fault of your tests, exactly --- there's
> something wrong in the existing make rules. I'm not sure what though.
> EXTRA_INSTALL should be getting set, according to pgxs.mk:
> temp-install: EXTRA_INSTALL+=$(subdir)
> but it evidently isn't.
Oh! The reason why not is that that line is inside "ifdef REGRESS",
and these subdirectories have no REGRESS tests. So we should move
that out to where it will apply regardless of that. Will fix.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
In-Reply-To: <17758.1535490505@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox