pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Craig Ringer <craig.ringer@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Thu, 07 Oct 2021 17:48:45 -0400
Message-ID: <179777.1633643325@sss.pgh.pa.us> (raw)
In-Reply-To: <202110072106.5vnpcxwxpmw6@alvherre.pgsql>
References: <202110072106.5vnpcxwxpmw6@alvherre.pgsql>

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2021-Oct-07, Tom Lane wrote:
>> Hmm.  I do see that Module::CoreList knows not only which modules
>> are in core but when they were brought in, so that does seem like
>> a really valuable reference to know about.  Let's just say something
>> like "You can consult Module::CoreList to find out whether and for
>> long a module has been present in the Perl core."

> WFM.

Concretely, then, I propose the attached.

			regards, tom lane

Attachments:

improve-test-perl-README.patch (text/x-diff, 1.2K) download diff --git a/src/test/perl/README b/src/test/perl/README index bfc7cdcfa3..94b00096fb 100644 --- a/src/test/perl/README +++ b/src/test/perl/README @@ -70,20 +70,15 @@ perldoc for the test modules, e.g.: perldoc src/test/perl/PostgresNode.pm -Required Perl -------------- - -Tests must run on perl 5.8.3 and newer. perlbrew is a good way to obtain such -a Perl; see http://perlbrew.pl . - -Just install and - - perlbrew --force install 5.8.3 - perlbrew use 5.8.3 - perlbrew install-cpanm - cpanm install IPC::Run - -then re-run configure to ensure the correct Perl is used when running -tests. To verify that the right Perl was found: - - grep ^PERL= config.log +Portability +----------- + +Avoid using any bleeding-edge Perl features. We have buildfarm animals +running Perl versions as old as 5.8.3, so your tests will be expected +to pass on that. + +Also, do not use any non-core Perl modules except IPC::Run. Or, if you +must do so for a particular test, arrange to skip the test when the needed +module isn't present. If unsure, you can consult Module::CoreList to find +out whether a given module is part of the Perl core, and which module +versions shipped with which Perl releases.

view thread (33+ messages)  latest in thread

Message-ID: <179777.1633643325@sss.pgh.pa.us>
Permalink:  ../179777.1633643325@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/179777.1633643325@sss.pgh.pa.us

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, daniel@yesql.se, pgsql-hackers@lists.postgresql.org, craig.ringer@enterprisedb.com, noah@leadboat.com
  Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
  In-Reply-To: <179777.1633643325@sss.pgh.pa.us>
  References: <202110072106.5vnpcxwxpmw6@alvherre.pgsql> <179777.1633643325@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox