pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Raise a warning if there is a possibility of data from multiple
Date: Thu, 08 Sep 2022 22:34:32 -0400
Message-ID: <1819.1662690872@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1+eBBPfP2-jNNe2WkfhvOUwofxopF8uC4ArNoYimyv9wg@mail.gmail.com>
References: <E1oW6W1-001vgA-TP@gemulon.postgresql.org>
	<CAD21AoDxqUc3kRfGaKC9-UsUW54mJ7iY2uy_76t0aTkQ=LikOA@mail.gmail.com>
	<CAA4eK1+Eta6demE4+xCGzRtjrd2K653e5D4CgBNMySp8i0nLjQ@mail.gmail.com>
	<CAD21AoAC9ELmteDHCCBjdHA0dRJbONdABafi1gOXUbio2LU52w@mail.gmail.com>
	<CAA4eK1+5EQZrQff1y-XFU5=GLvZT43cuPPVRhpsTGvvA+Bx-_Q@mail.gmail.com>
	<3952373.1662645480@sss.pgh.pa.us>
	<CAA4eK1+eBBPfP2-jNNe2WkfhvOUwofxopF8uC4ArNoYimyv9wg@mail.gmail.com>

Amit Kapila <amit.kapila16@gmail.com> writes:
> Fair enough. Do you mind being consistent in this regard for logical
> replication-related code?

As long as not too many individual changes are involved, sure.
But consistency of this sort doesn't seem worth creating a lot
of back-patching land mines, IMO.

> BTW, is there a reason we prefer to write in
> one or another way (with or without appending schema_name)?

In places where we can trust the search_path to be just pg_catalog,
there's no real strong reason to write a schema name, I think.

			regards, tom lane





view thread (9+ messages)

Message-ID: <1819.1662690872@sss.pgh.pa.us>
Permalink:  ../1819.1662690872@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1819.1662690872@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, sawada.mshk@gmail.com, akapila@postgresql.org
  Subject: Re: pgsql: Raise a warning if there is a possibility of data from multiple
  In-Reply-To: <1819.1662690872@sss.pgh.pa.us>
  References: <E1oW6W1-001vgA-TP@gemulon.postgresql.org> <CAD21AoDxqUc3kRfGaKC9-UsUW54mJ7iY2uy_76t0aTkQ=LikOA@mail.gmail.com> <CAA4eK1+Eta6demE4+xCGzRtjrd2K653e5D4CgBNMySp8i0nLjQ@mail.gmail.com> <CAD21AoAC9ELmteDHCCBjdHA0dRJbONdABafi1gOXUbio2LU52w@mail.gmail.com> <CAA4eK1+5EQZrQff1y-XFU5=GLvZT43cuPPVRhpsTGvvA+Bx-_Q@mail.gmail.com> <3952373.1662645480@sss.pgh.pa.us> <CAA4eK1+eBBPfP2-jNNe2WkfhvOUwofxopF8uC4ArNoYimyv9wg@mail.gmail.com> <1819.1662690872@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox