pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tv@fuzzy.cz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: pgsql-committers <pgsql-committers@postgresql.org>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Generational memory allocator
Date: Fri, 24 Nov 2017 14:13:12 -0500
Message-ID: <18578.1511550792@sss.pgh.pa.us> (raw)
In-Reply-To: <31255.1511497154@sss.pgh.pa.us>
References: <E1eHa4J-0006hI-Q8@gemulon.postgresql.org>
	<20171123001649.y2nf7422iay6cw3v@alap3.anarazel.de>
	<CANP8+jKoT=Pg5W_3FcKiDf+FMrJhFYacxt_g5E0=tkmb5s8M6g@mail.gmail.com>
	<20171123193936.fncfnar5wkpx56mw@alap3.anarazel.de>
	<21043.1511467602@sss.pgh.pa.us>
	<c09b1f12-8042-1e77-1b3e-ca68a2b44167@fuzzy.cz>
	<20171123214636.unwkrkunr7m2bkii@alap3.anarazel.de>
	<13547.1511474676@sss.pgh.pa.us>
	<ce281fac-b6f5-2d86-a9eb-4cc04d5d4bce@fuzzy.cz>
	<31255.1511497154@sss.pgh.pa.us>

I wrote:
> Tomas Vondra <tv@fuzzy.cz> writes:
>> Thanks. Do we need to do something similar to the other memory contexts? 
>> I see Slab does not do this at all (assuming it's not necessary), and 
>> AllocSet does this in a different way (which seems a bit strange).

> Hm ... the coding in AllocSet is ancient and I have to say that I don't
> like it as well as what I put into generation.c.

I take that back: the current coding of padding in AllocChunkData only
dates back to 7e3aa03b.  But I still don't like it, and will migrate
generation.c's version into aset.c.  And maybe improve the comments.

BTW, it appears that some of the confusion in generation.c can be
accounted for by not having entirely followed the changes in 7e3aa03b.

			regards, tom lane




view thread (37+ messages)  latest in thread

Message-ID: <18578.1511550792@sss.pgh.pa.us>
Permalink:  ../18578.1511550792@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/18578.1511550792@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, tv@fuzzy.cz, andres@anarazel.de, simon@2ndquadrant.com, andrew@dunslane.net
  Subject: Re: pgsql: Generational memory allocator
  In-Reply-To: <18578.1511550792@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox